Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     stanley.chu@mediatek.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com,
        linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pm4i5syu.fsf@ca-mkp.ca.oracle.com>
References: <20230712064832.44188-1-yang.lee@linux.alibaba.com>
Date:   Sun, 23 Jul 2023 15:27:26 -0400
In-Reply-To: <20230712064832.44188-1-yang.lee@linux.alibaba.com> (Yang Li's
        message of "Wed, 12 Jul 2023 14:48:32 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J9CRqLoenG59VpXgWQ8hYYzTDjrnBU4TPGto5+hrg95Y7tG/kUZ1ylN7n2Uk?=
 =?us-ascii?Q?i1ZjuZz9u6r4e2i+lJaLr2tLrsM/X6LFzkj/jE/4/ZLs3z0KTyvzVAG4gwZw?=
 =?us-ascii?Q?rte3+am9/3k9IlyClbHrXYAQep0ppuaJTeKdO6r/5nEEOaMZjd2y/rOZIZNz?=
 =?us-ascii?Q?pa0ZeP4XbKGcMzAzBcArZBFthdR0S7pvcTZRtIxLxh/DCVsaXBfwZHdLdzwX?=
 =?us-ascii?Q?pGKToXIEtoNhR/zCO3qhyDnGgGK3WyK0yv6Le4UPdFDUhN44sxnfaSlWcMna?=
 =?us-ascii?Q?VjadvzPY6fl8o+5RsTgXs0W/Sr6C6xD74N6Jh2XTHU66h6Dfw7CxASjOwyYd?=
 =?us-ascii?Q?ey54/1UgQd7n66BPpsbMXM8zGaZpW4C3sJ+bjBfdLFkPzOsGOBjyEiAtX7J6?=
 =?us-ascii?Q?E5iA6EU/X5r9AHZR6TwnieWVteQkDaMQ5bz9T9MMIntwZ2ZR0CD3Aqe+tI7r?=
 =?us-ascii?Q?Een2vHQ/EnOsucSBlAMhbKKsAGexz5mxNHFrSgC3B1bhGUQxPY4TiMEkfq4b?=
 =?us-ascii?Q?Iv4RrBu0/wo/t0o/cn97T36NSyek5B9pVsdVK08Fre82bOwkzWeCpV3SqlmA?=
 =?us-ascii?Q?DMP4HFhGSQqSvEcYvBMA7W1fvgl39W0lVSlYUCGyMM99bn/82it6McchlG+j?=
 =?us-ascii?Q?QEYrbABElrtGodQ47SO77KTBQVlh1WL1E2YvdXBtj6rvFJJZQr0sJzZcFaQV?=
 =?us-ascii?Q?j9Fi2Zqh0L5reQ5baezEw6oS4d9hZ2PoFoU452DRGAdCyJAmipYwwhYKfc4r?=
 =?us-ascii?Q?rAbXp0QozKv9RKw9pdg/KJHK5DDddjHCQkQoXAB45U+YkSY/4n1hu9+vzmyZ?=
 =?us-ascii?Q?KDFsQRLJx/6PuPg4EwmsDBkSNVxOz2HIFAbRQLaq3/APFYmZHeDz3d81g5np?=
 =?us-ascii?Q?aCfnBl5fPyPW7yDwnueOmDru+tMEVetDZFVjWHN07IHiPceZ77dMd7YrzcqF?=
 =?us-ascii?Q?XtGhf9Xzkfw5Wgjm3NbEf3QItkP+WE9Nxf2XZhTc8R07F3Y2EpmPkZWZIJPh?=
 =?us-ascii?Q?pCfzE9QpM5Z4hW6sTB39tteBRSK7eK5X40ElgiQlkS9f4aI5EPyigmxJDOwv?=
 =?us-ascii?Q?9HiZnZ/MDCVYZBArFeDIuyV5+xj7A13rMcl1mb9fnYJCgUnMzol9apY30AJm?=
 =?us-ascii?Q?/GtymRwLfnh7shDTxljOkhYdsRA9rj76e/JVsMyQjLkrLsVUFVPElP62doQC?=
 =?us-ascii?Q?stbcjANmEOkndGcxx0yB+kNH2Qo8cFADhl1K8V3y4Nh0MIIx2SMv4td20l7q?=
 =?us-ascii?Q?pF/w5JuxA9gf8N7u1j8EtWsLpiI7x/hcTaysBOvKirO/KqybnlpXA84Xh/jF?=
 =?us-ascii?Q?y49ZEYqKHHI6Kyi163CGzHLdVMYtqBkKxBjj/MaQbofMMrsCJ6jKP64GT96N?=
 =?us-ascii?Q?AAaxjBbp+504/WGqGEgJroI6JC9M3OUpa8n3Lm8CkoqTlWvbl9jnZ463aKTE?=
 =?us-ascii?Q?8p9EwsLHstobpn8Y0MkiBiwgBJJYQX4DKbT4joDcqOyaFHU3+b6OGGUTfnLm?=
 =?us-ascii?Q?HcsZdItYS9Q2UxSlcWPXXWal9rylj38tyPNsqKAGyGReEwcQwL0hskJ69bJz?=
 =?us-ascii?Q?gdN+9OBfz81i0ktlA4DD5zOroJoEn6j8ni1cWAgAl822HwUu6L2ifZ0IQPAR?=
 =?us-ascii?Q?0Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?7vtq5UBneQZB7dxSf7LqDsCaYLgbnicFrVkMMaeq6DJ31C5vQSpXyrIV8Obv?=
 =?us-ascii?Q?kZJmRUE4rA4omriGnnEnO73S8ScfGyAX6V/cdRetxgJx3uBACxVsqv99o/zx?=
 =?us-ascii?Q?lGC5yx2+I7jRu60+CsXSewCfOHLGqVQ+oxhGQuGuji+sNyOka96Kf362fQAe?=
 =?us-ascii?Q?aWfWJr0mnVnrRO5hjS/3GzoNvAZMHRw/fwAXWmasSWrldH17sndbh/uPlIrd?=
 =?us-ascii?Q?H2agyYRPinrlZaI3yTGai7AfvAxcc93Lu1OyaxcAFsfrCbSyKJKHoLFKr7Hr?=
 =?us-ascii?Q?XVDG4RoC3BAwH/G66laL8knJyJRF81lYBErEfEH+2ypLSWqfNvOg03ezvPa4?=
 =?us-ascii?Q?6kqhu05O0juqeXczWJ3QIqmiAt8KG7veBXuM54ARWtnJqNIPg/B0vgZ/3+hz?=
 =?us-ascii?Q?m4T8bmg318h9rwPTRa0F9lDyBslkugM+cgsCiKz4nJr36Gq8R07Zn70vwi1K?=
 =?us-ascii?Q?WWa1Jqh1H8EzFWzGTgfSQ4j2KfSAUqzHsWykkRuJCEseDPW2zwHh8/IGWJDq?=
 =?us-ascii?Q?KEZLWQpJosaFXaXyY6HdWpc8duTu5YGLRtG4CwGYHmKPVm8w49rUpr8XCiQn?=
 =?us-ascii?Q?nfokV4dakzldogqBPMzbtEpXrKvrLhOOh2r8J758kWAhL4rWPJLetPJ4pnsK?=
 =?us-ascii?Q?6YbqWM08/f1kpGGeSHwdFrV/XMRA1g82MkoUUB4cjkLaRHXs5WQ3W2VRvEWd?=
 =?us-ascii?Q?cPwiGs525mWJVegTaQypeG1GLv3OwDrqJd/DdkrRyrzUzo/Xy7kuNxu9kApJ?=
 =?us-ascii?Q?kjzW3bOo3ACBbdAGS60quyMXy6f6PHzVTw3AT4540jEn+GJ/e9TU7F3583cV?=
 =?us-ascii?Q?bhHhWSNF6/PbzhO1No+PlvijzMZeuHN4qO3H7Ws/qSEN6K/2YU+qw/2Pb6p/?=
 =?us-ascii?Q?eU7T959COar6UvDcMVzYVT/iCok4RDHuzLm6h6JoCiWvTJ+r/TVH+GNJcRZX?=
 =?us-ascii?Q?y4y4cOmuqEivmDytrnLJrriypOWsu8DnU5OqdVeXFQ4UUeRLSJ+Atkfc4fO5?=
 =?us-ascii?Q?OADT?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 765ad909-8ab1-4edc-7a87-08db8bb2dc71
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2023 19:27:32.2712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i2Dv7k7rkcmewAWSNv9v9S23xDMQZBQTs/e8LxHnIMYMCjAmiqTb2EyLRg9gu/qihNsKI8yFKI3JdJ+StWyQhrqSfKGONrtygecLBR9ZDR8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7495
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-23_08,2023-07-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=897 spamscore=0
 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307230182
X-Proofpoint-GUID: 20BYSjVp2nO_5DjyC-8DGGC9Iw5lgZXq
X-Proofpoint-ORIG-GUID: 20BYSjVp2nO_5DjyC-8DGGC9Iw5lgZXq
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Yang,

> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering