Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2365096rwo; Sun, 23 Jul 2023 13:35:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlHSYJ2T3oFce3HQQaCqKgZ58zBIuNASUfCyxPz7wYPwk9JCp+OKXbfpGJN8yDaJUb3Eu+dc X-Received: by 2002:a17:902:e811:b0:1b8:9b17:f63d with SMTP id u17-20020a170902e81100b001b89b17f63dmr7974998plg.23.1690144499947; Sun, 23 Jul 2023 13:34:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690144499; cv=none; d=google.com; s=arc-20160816; b=uvkTrRzFX+mnWcnk+VYE5NKKOrQSPZiEgGi3sRMCWxgsVO8rqHATcglnlLH+pr2Sou d/pi1nEqzIeyfV/AX860UQdnmEaLWG77OV5dyYesZ7ECjJqpLfj7sSpKH5gijrLhBqHV OUkembCtJp8d4o4MnR7gF6fKjJXzJVAJ8WcR1gh+DA3UsGJ8BfiEUnteGa335bOtbvy6 x7W3GbgbmTsgiSlF3vwZUptZDLACC7fNP0ctERvxhdYNdixx9U/XByznTatLvt/hZbk3 E4CxqEYkM0Z+MdiGk/x88rQYB7zJIc7Nj8S0V69xvLbm8ABlVdm9BVjR6l9CfaDak+qP 9aOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=5O0T8hO3ew3JwW9ro5StSzk+SupCf/P1lFj26nNGs4M=; fh=xjAeyIPcqevt7tegn9JgQph1y2vMHvvv0P307ADP2Q4=; b=sHYlGOvdkmve4TAx9A/X5r6sZDSg7LVEc3kXo/8NzhQatVVFHEoLKt9ubnTHymkxYV e9ArjPsc+fO0TsMWQfnloO+DCrAVllZgL2hPbOeu0tiwEy7fOa+swd/g+MMxcld6EluP pF+1sxe8V4TW9HcIfGXBtbhLWB4ab8MQb8KB4OxCT/e81PAhO3n2wGxGPU8vfraPUqmp 6c1Sy6Sd1Pue7Hka2THkp8M9CzPotWSIbEjm9wpBRwKpoE9e6wpZL8GaMdxlRcSi9N7G tIhJc9EtBouCjSLWwygvhbZ8QmaoF/CDnNlXl+Ns+UrUpO6RlhuZX490c4zjDSe0DVKq 0ZPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i04gOhYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b00563856f6d3bsi5770503pgp.55.2023.07.23.13.34.48; Sun, 23 Jul 2023 13:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i04gOhYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbjGWUGL (ORCPT + 99 others); Sun, 23 Jul 2023 16:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbjGWUGK (ORCPT ); Sun, 23 Jul 2023 16:06:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7741B1BE; Sun, 23 Jul 2023 13:06:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04FBA60E9A; Sun, 23 Jul 2023 20:06:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE29FC433C8; Sun, 23 Jul 2023 20:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690142768; bh=MYDNII/nRbpdhoxLfX/zeWMDQLkBfuAoQG5un5EegG8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=i04gOhYl/e9pCTC+Qjr0+IHT70ErCt815FZsNDMNWXOyWLAtfFsG5RRDgy/ifMEYi ocuIRDmhrayU0SnG3tshMAydV1PAx5CqH6z636iru4IYvtGpvzPlkrKyAXwVcporwo xN7gQ8SSCjeGdg5g3sHi+/+PXffTeKrzQbsJ7Ba1tyxmDeXLPCWXSP7nMhB7Zt21Kb xzTthLBnKMf4WlOuXZE2aW4YkWJgrKhkOPlIBw48KjZHkV3U+OUUh7Jgh645JuBoRg 5pXX9f85FgT316SIJ0WqprfJYTbt/k3S85n2UugXt5ZXSgq3h6aOvObqny3LV/lRzA VeVGP5CPUOpmw== Message-ID: <1703ab6e-8567-8574-f011-af19813f97e8@kernel.org> Date: Mon, 24 Jul 2023 05:06:04 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 09/15] PM / devfreq: Switch to dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs To: Manivannan Sadhasivam , vireshk@kernel.org, nm@ti.com, sboyd@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_asutoshd@quicinc.com, quic_cang@quicinc.com, quic_nitirawa@quicinc.com, quic_narepall@quicinc.com, quic_bhaskarv@quicinc.com, quic_richardp@quicinc.com, quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com, bmasney@redhat.com, krzysztof.kozlowski@linaro.org, linux-kernel@vger.kernel.org References: <20230720054100.9940-1-manivannan.sadhasivam@linaro.org> <20230720054100.9940-10-manivannan.sadhasivam@linaro.org> From: Chanwoo Choi Content-Language: en-US In-Reply-To: <20230720054100.9940-10-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23. 7. 20. 14:40, Manivannan Sadhasivam wrote: > Some devfreq consumers like UFS driver need to work with multiple clocks > through the OPP framework. For this reason, OPP framework exposes the > _indexed() APIs for finding the floor/ceil of the supplied frequency of > the indexed clock. So let's use them in the devfreq driver. > > Currently, the clock index of 0 is used which works fine for multiple as > well as single clock. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/devfreq/devfreq.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index e36cbb920ec8..7686993d639f 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -88,7 +88,7 @@ static unsigned long find_available_min_freq(struct devfreq *devfreq) > struct dev_pm_opp *opp; > unsigned long min_freq = 0; > > - opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &min_freq); > + opp = dev_pm_opp_find_freq_ceil_indexed(devfreq->dev.parent, &min_freq, 0); This patch changed the used function from dev_pm_opp_find_freq_ceil to dev_pm_opp_find_freq_ceil_indexed even if there are no supporting of the multiple clocks and then dev_pm_opp_find_freq_ceil is not removed from OPP. I think that it is better to use dev_pm_opp_find_freq_ceil_indexed when need to support multiple clocks with real case. > if (IS_ERR(opp)) > min_freq = 0; > else > @@ -102,7 +102,7 @@ static unsigned long find_available_max_freq(struct devfreq *devfreq) > struct dev_pm_opp *opp; > unsigned long max_freq = ULONG_MAX; > > - opp = dev_pm_opp_find_freq_floor(devfreq->dev.parent, &max_freq); > + opp = dev_pm_opp_find_freq_floor_indexed(devfreq->dev.parent, &max_freq, 0); > if (IS_ERR(opp)) > max_freq = 0; > else > @@ -196,7 +196,7 @@ static int set_freq_table(struct devfreq *devfreq) > return -ENOMEM; > > for (i = 0, freq = 0; i < devfreq->max_state; i++, freq++) { > - opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &freq); > + opp = dev_pm_opp_find_freq_ceil_indexed(devfreq->dev.parent, &freq, 0); > if (IS_ERR(opp)) { > devm_kfree(devfreq->dev.parent, devfreq->freq_table); > return PTR_ERR(opp); > @@ -2034,18 +2034,18 @@ struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, > > if (flags & DEVFREQ_FLAG_LEAST_UPPER_BOUND) { > /* The freq is an upper bound. opp should be lower */ > - opp = dev_pm_opp_find_freq_floor(dev, freq); > + opp = dev_pm_opp_find_freq_floor_indexed(dev, freq, 0); > > /* If not available, use the closest opp */ > if (opp == ERR_PTR(-ERANGE)) > - opp = dev_pm_opp_find_freq_ceil(dev, freq); > + opp = dev_pm_opp_find_freq_ceil_indexed(dev, freq, 0); > } else { > /* The freq is an lower bound. opp should be higher */ > - opp = dev_pm_opp_find_freq_ceil(dev, freq); > + opp = dev_pm_opp_find_freq_ceil_indexed(dev, freq, 0); > > /* If not available, use the closest opp */ > if (opp == ERR_PTR(-ERANGE)) > - opp = dev_pm_opp_find_freq_floor(dev, freq); > + opp = dev_pm_opp_find_freq_floor_indexed(dev, freq, 0); > } > > return opp; -- Best Regards, Samsung Electronics Chanwoo Choi