Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765187AbXJZWn1 (ORCPT ); Fri, 26 Oct 2007 18:43:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751955AbXJZWnL (ORCPT ); Fri, 26 Oct 2007 18:43:11 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:42365 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbXJZWnJ (ORCPT ); Fri, 26 Oct 2007 18:43:09 -0400 Date: Fri, 26 Oct 2007 15:42:40 -0700 (PDT) From: Linus Torvalds To: Zach Brown cc: Karl Schendel , Benjamin LaHaise , Andrew Morton , Linux Kernel Mailing List , Nick Piggin , Leonid Ananiev , Chris Mason Subject: Re: [PATCH] Fix bad data from non-direct-io read after direct-io write In-Reply-To: <47226A75.1020008@oracle.com> Message-ID: References: <47225835.4050309@datallegro.com> <47226A75.1020008@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 18 On Fri, 26 Oct 2007, Zach Brown wrote: > > I think that test should be changed to How about not testing at all? Which was what the old code did. Just do the invalidate unconditionally for any writes, and screw the end result of the invalidate, since we cannot afford to overwrite the previous return value anyway in any realistic scenario? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/