Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Jul 2023 23:15:55 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     "huzhi001@208suo.com" <huzhi001@208suo.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: Fix warnings in mshyperv.h
Message-ID: <ZL20q7yVHqX0F8K8@liuwe-devbox-debian-v2>
References: <tencent_7A4BAF2CDEE6AC56AB5ABBCE9CA1C2FE5205@qq.com>
 <f5f5e7f2627ea55d81bc2d39420c40e8@208suo.com>
 <BYAPR21MB16885FB2E77FC9ADB1C8B48DD736A@BYAPR21MB1688.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BYAPR21MB16885FB2E77FC9ADB1C8B48DD736A@BYAPR21MB1688.namprd21.prod.outlook.com>
Precedence: bulk

On Wed, Jul 12, 2023 at 09:06:30PM +0000, Michael Kelley (LINUX) wrote:
> From: huzhi001@208suo.com <huzhi001@208suo.com> Sent: Wednesday, July 12, 2023 4:23 AM
> > 
> > The following checkpatch warnings are removed:
> > WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> 
> The "Subject:" of the patch should probably start with "x86/hyperv",
> not "clocksource".  Usually I look back at the commit history of a
> particular file and try to be consistent with the Subject: prefix that
> has been used in the past.  "x86/hyperv" is typical for this
> include file.
> 
> Other than that,
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

There is only one warning fixed.

I changed the subject line and commit message.

Applied to hyperv-fixes. Thanks.

> > 
> > Signed-off-by: ZhiHu <huzhi001@208suo.com>
> > ---
> >   arch/x86/include/asm/mshyperv.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/include/asm/mshyperv.h
> > b/arch/x86/include/asm/mshyperv.h
> > index 88d9ef98e087..fa83d88e4c99 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -5,7 +5,7 @@
> >   #include <linux/types.h>
> >   #include <linux/nmi.h>
> >   #include <linux/msi.h>
> > -#include <asm/io.h>
> > +#include <linux/io.h>
> >   #include <asm/hyperv-tlfs.h>
> >   #include <asm/nospec-branch.h>
> >   #include <asm/paravirt.h>