Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Jul 2023 22:45:32 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [patch 47/58] x86/apic: Remove pointless arguments from
 [native_]eoi_write()
Message-ID: <ZL2tjHz0hvfEyrZc@liuwe-devbox-debian-v2>
References: <20230717223049.327865981@linutronix.de>
 <20230717223225.875917164@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230717223225.875917164@linutronix.de>
Precedence: bulk

On Tue, Jul 18, 2023 at 01:15:47AM +0200, Thomas Gleixner wrote:
> Every callsite hands in the same constants which is a pointless exercise
> and cannot be optimized by the compiler due to the indirect calls.
> 
> Use the constants in the eoi() callbacks and remove the arguments.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/hyperv/hv_apic.c             |    6 +++---

The change looks trivially correct.

In conjunction with the function name change:

Reviewed-by: Wei Liu <wei.liu@kernel.org>