Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 08:23:22 +0800
From:   Jisheng Zhang <jszhang@kernel.org>
To:     Drew Fustini <dfustini@baylibre.com>
Cc:     Conor Dooley <conor@kernel.org>, Guo Ren <guoren@kernel.org>,
        Fu Wei <wefu@redhat.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Robert Nelson <robertcnelson@beagleboard.org>,
        Jason Kridner <jkridner@beagleboard.org>
Subject: Re: [PATCH 1/3] riscv: dts: thead: add BeagleV Ahead board device
 tree
Message-ID: <ZL3Eenj4lGZDhZTM@xhacker>
References: <20230722-upstream-beaglev-ahead-dts-v1-0-ccda511357f4@baylibre.com>
 <20230722-upstream-beaglev-ahead-dts-v1-1-ccda511357f4@baylibre.com>
 <20230723-savor-trolling-e35ed4a7a751@spud>
 <ZL1jlacHj7sgNg8M@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZL1jlacHj7sgNg8M@x1>
Precedence: bulk

On Sun, Jul 23, 2023 at 10:29:57AM -0700, Drew Fustini wrote:
> On Sun, Jul 23, 2023 at 11:32:17AM +0100, Conor Dooley wrote:
> > On Sat, Jul 22, 2023 at 02:55:39PM -0700, Drew Fustini wrote:
> > 
> > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> > > @@ -0,0 +1,61 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > 
> > Hmm, should this not be dual licensed?
> > I notice the other th1520 stuff isn't either..
> 
> Good point, I'll resubmit with a dual license.
> 
> Jisheng: are you okay with the other arch/riscv/boot/dts/thead files
> changing to a dual license?

When cooking the initial patch, I wrote the lpi4a dts files from
scratch based on sipeed opened sch file, and currently only I made
contributions to them, so it's easy to make the lpi4a dts files
dual license.

However, when constructing the th1520.dtsi, I refered the T-HEAD's
opensourced yocto repo(in fact, that's the only sourcecode/doc I have
at that time), and the license there is GPL-2.0. That's
also the reason why copyright of Alibaba Group Holding Limited is
added to th1520.dtsi. I'm not sure how to make th1520.dtsi dual
license. At least, this needs help from Guo Ren. Any suggestion is
appreciated.

> 
> > 
> > 
> > > +	memory@0 {
> > > +		device_type = "memory";
> > > +		reg = <0x0  0x00000000  0x1 0x00000000>;
> > 
> > There's some extra spaces in here for some reason.
> 
> Thanks for spotting that. I'll fix when I resubmit with dual licnese.
> 
> Drew