Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2544293rwo; Sun, 23 Jul 2023 18:32:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEq0dvySONplFIgp+7cHBIv5GbHFQat+LGfFzoSk87qcjXQaGQh0GNo92dB1/188GpppkjO X-Received: by 2002:a17:906:7792:b0:99b:5a73:4d09 with SMTP id s18-20020a170906779200b0099b5a734d09mr8746336ejm.43.1690162365117; Sun, 23 Jul 2023 18:32:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690162365; cv=none; d=google.com; s=arc-20160816; b=KlxPVdhlxrKCDl6o0KB1ykHWdTmGuG6tZa2QxJ4pU1IGCFqRFquKlKrZN+9H0v2afh wUQt6J+qbqjWzJbKRoQsB/T2Cvc5Ouqgb0W8ZpTMzfXAU3IGMGsf0tJU+sm9R6qBlLWL a2ygvbO8nJdwmYfe/YQgURKdXs8U3myXnEqbpkAjBAY3tuGaOP7UEwANnZsyqkXYnw8e I+LLf2z3eQncCJk2PzKK4d1jHlgJ4gEMyPkujFzDQRWg+jjhsDhADQn+2+tNh/j17Bk2 iCu5b9x5T89GbO7WAdixKr2saLOr3Pc6rBhs3xL/ztvb9uwpwHgSFr92eFBcrNfsvldR p73g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JBBnluntryZ+4TSbERnS7JZgQZlsqCzDhva/hKq2Yjs=; fh=+KSPUGIz0J1pmCKKg9k4EU0KH/qHle7/sTugRYW6kkQ=; b=JA3fRP5UiuuACdaQUdzvfZbim8YrLb/PrktYHqfYW7FYIOuJOuHUVcKOfwfddROH0t mNsiR0vUwSA/ajfXBRVjQjnSMQx8LhqMB8MVNk4dEiPEczZNIWmC7OFRAyV6GG5fW5N2 fTe82a/LBMkU9DAVDwmsBhv3mcRiJjXfxfGLDDd61DutQiOgzYrsbRG879s0i4wdLrXX 62Kn2gxXbigZAwqyfSgDzFvq97Bx5fdLK4WM9O1ttHomd+CvexPWV7E0FDreYRE1lLyL Dku9iSClnR3/YFHNHm1oukSsakpwYualUHCPyKJkaSfTJlbtS9wlY1cfKHy6mgXFFYpF F0Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eo5rYmZU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a2-20020a1709064a4200b00997e8b6eaa7si5573165ejv.510.2023.07.23.18.32.21; Sun, 23 Jul 2023 18:32:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eo5rYmZU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbjGXBWT (ORCPT + 99 others); Sun, 23 Jul 2023 21:22:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbjGXBWA (ORCPT ); Sun, 23 Jul 2023 21:22:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9948B172A; Sun, 23 Jul 2023 18:21:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 495C360EEB; Mon, 24 Jul 2023 01:21:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CCA7C433C7; Mon, 24 Jul 2023 01:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690161669; bh=Fz6RXpQ9T59WQ0G81m7lRvqJdxJVsd3sjQGZu9os1Ns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eo5rYmZUc1Fyrg1SQ7LVE5XEY6hB/gno9bCSqpHt1E/iF/ezeTFolAvlUMCaIzACh 38+HLL6iizlY7ngcJ2sv7jZzQkyXY+oGtHaHab1vxk5sossn5Y1UmvAh/RE1tlzeue 2tKjUWFj0tJn9OE+K2v4xfNOubQ0GfCt1EiWhHnUBKeqHrQleFITlhepcgCki/xHpv uj5/6ImsUFlWW6qs1AgOHhUMuqQ22KCiD0O1VGh3CGhhKx0aLTF3IU6zkxObmLc0Sq yP9qIoW8QLq4csFsjzfR4D8CpPdNvKhiUtWd7A2oXTK9T5ndUTYcPzpAdqqdnSjsGC D/SwIjlv6EZ9w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Immad Mir , Dave Kleikamp , Sasha Levin , shaggy@kernel.org, jfs-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 6.4 58/58] FS: JFS: Check for read-only mounted filesystem in txBegin Date: Sun, 23 Jul 2023 21:13:26 -0400 Message-Id: <20230724011338.2298062-58-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724011338.2298062-1-sashal@kernel.org> References: <20230724011338.2298062-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.5 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Immad Mir [ Upstream commit 95e2b352c03b0a86c5717ba1d24ea20969abcacc ] This patch adds a check for read-only mounted filesystem in txBegin before starting a transaction potentially saving from NULL pointer deref. Signed-off-by: Immad Mir Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_txnmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index ffd4feece0785..ce4b4760fcb1d 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -354,6 +354,11 @@ tid_t txBegin(struct super_block *sb, int flag) jfs_info("txBegin: flag = 0x%x", flag); log = JFS_SBI(sb)->log; + if (!log) { + jfs_error(sb, "read-only filesystem\n"); + return 0; + } + TXN_LOCK(); INCREMENT(TxStat.txBegin); -- 2.39.2