Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2545397rwo; Sun, 23 Jul 2023 18:34:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlFW5FLTP82Ts2dsjvlVKxPQjf0pxyVHkg/77AIPnFmzQd9TB1IBS/M0TQcNl5Il8wZKwTXB X-Received: by 2002:a17:902:d488:b0:1bb:77a2:edda with SMTP id c8-20020a170902d48800b001bb77a2eddamr7543091plg.36.1690162475780; Sun, 23 Jul 2023 18:34:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690162475; cv=none; d=google.com; s=arc-20160816; b=DiewNhN3/aBUagyNB9yxFDFPfHqFOL1FORAfLro6pE7Qpvl9jKTLdZqocNl66D1Vgf lhvsJROGfDlNGUHSs6mNoYGYKe89eUPhUIwWV2IAaysx/OH+AjtYHsMWgz/AokVhqz9q DZLae8RdS5vaHo4zI/sxvunglbSdcBkhGDwvs4P7lcAw4iMKNjpsTMIdYKn4jrMKjQgk dZZiGywJfufdll0EFqpyJbIk+3LnNyH19ZatNMtxzmFll4KsSnoeqOfiiCr6mgcmwt0d +sLwVnkK3dMTDAkgP/ZcRz/pTPxgmYVwQIbC4PHcGX1xojNJUCNWJd/MLYS81aaD3DUO Guxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vxqFAvMCrMHOol2cWF+VPY8cya6GC7EoI549Ce48ons=; fh=CSGPNZHLsfuAX2OVo5p96jRkNsfwGKX1yFKXjDfuTTg=; b=uNgqI349y16RAD3fAqxXO1d+v9z8zRafbPPVqRkmvsl8g3lW1uxuRud7CF+dyCo5fD g32QgEM/QZSMVh6ZHIAP++a0Y540Y6nhyHkWNBvBdyrV99btf5K73JryiajfwdQFvEfk L9MReD5Xn/WUIACDuuPWWuhGo/LX5BtPnzAWMoAOgInLJHjnldX1Su/sGYAoQmsLuHXt KyEhm/xdQnEk0nAqny608+gOD2cyqntTXCwStLRNZrIQuxfjjT5I7Mvd1U2f4SgP4LbY KCNN8JjQhbALKzrcxaFvm5oez9IXen+lj76cTJudknumN6GDCPO0rZSlUz0sjde9CK+I ExGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m8haTTgw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jf10-20020a170903268a00b001bb2d103084si7511542plb.519.2023.07.23.18.34.23; Sun, 23 Jul 2023 18:34:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m8haTTgw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjGXBUI (ORCPT + 99 others); Sun, 23 Jul 2023 21:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbjGXBUH (ORCPT ); Sun, 23 Jul 2023 21:20:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB7E1BB; Sun, 23 Jul 2023 18:19:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F61760F05; Mon, 24 Jul 2023 01:18:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E123EC433C7; Mon, 24 Jul 2023 01:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690161517; bh=Gm7xMPFN6RJVQ+Wp6OwKlm6mqZ19x2ksKi4VSKNYyFk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m8haTTgwnKbs/GeUkvRYMRYmlPVTzngCPso7ejazfr2JnadFzn0xRFZFv/i1TyAp1 en+X50i/+MMCgZyGp1JEnWwyGK5n2Jw5YMyw+7KLCW4nu1RNn0UfLLw31a8IFi+Dm1 tvqtiimp1HejkbgabEUvayUA0xHbEFY4QhxjZtpPMm4Os7Cg0TQMZZHpdi5mWNN5Cq NqDKAbHcS790z3MLVkTphlgTwlSxoaYiEsf6OnW0kCBuWUfUtlYvX4DWzsMMsbGeOw KT6EuP2iU/wvYpVXQOmf2KVsmuzRy3Rkq0U9Og3aAtTVhub865ez9UHmiNHsvvakvq Jxt1fnAidxapg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Moti Haimovski , Dani Liberman , Oded Gabbay , Sasha Levin , obitton@habana.ai, ttayar@habana.ai, kelbaz@habana.ai, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.4 32/58] accel/habanalabs: fix mem leak in capture user mappings Date: Sun, 23 Jul 2023 21:13:00 -0400 Message-Id: <20230724011338.2298062-32-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724011338.2298062-1-sashal@kernel.org> References: <20230724011338.2298062-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.5 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Moti Haimovski [ Upstream commit 314a7ffd7c196b27eedd50cb7553029e17789b55 ] This commit fixes a memory leak caused when clearing the user_mappings info when a new context is opened immediately after user_mapping is captured and a hard reset is performed. Signed-off-by: Moti Haimovski Reviewed-by: Dani Liberman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin --- drivers/accel/habanalabs/common/habanalabs_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/habanalabs/common/habanalabs_drv.c b/drivers/accel/habanalabs/common/habanalabs_drv.c index 1ec97da3dddb8..70fb2df9a93b8 100644 --- a/drivers/accel/habanalabs/common/habanalabs_drv.c +++ b/drivers/accel/habanalabs/common/habanalabs_drv.c @@ -13,6 +13,7 @@ #include #include +#include #define CREATE_TRACE_POINTS #include @@ -218,6 +219,7 @@ int hl_device_open(struct inode *inode, struct file *filp) hl_debugfs_add_file(hpriv); + vfree(hdev->captured_err_info.page_fault_info.user_mappings); memset(&hdev->captured_err_info, 0, sizeof(hdev->captured_err_info)); atomic_set(&hdev->captured_err_info.cs_timeout.write_enable, 1); hdev->captured_err_info.undef_opcode.write_enable = true; -- 2.39.2