Date: Fri, 26 Oct 2007 16:14:10 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Zach Brown <zach.brown@oracle.com>
cc: Karl Schendel <kschendel@datallegro.com>,
       Benjamin LaHaise <bcrl@kvack.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Nick Piggin <nickpiggin@yahoo.com.au>,
       Leonid Ananiev <leonid.i.ananiev@linux.intel.com>,
       Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] Fix bad data from non-direct-io read after direct-io
 write
In-Reply-To: <47227015.6060708@oracle.com>
Message-ID: <alpine.LFD.0.999.0710261611511.30120@woody.linux-foundation.org>
References: <47225835.4050309@datallegro.com>
 <alpine.LFD.0.999.0710261425240.30120@woody.linux-foundation.org>
 <47226A75.1020008@oracle.com> <alpine.LFD.0.999.0710261541410.30120@woody.linux-foundation.org>
 <47227015.6060708@oracle.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 26


On Fri, 26 Oct 2007, Zach Brown wrote:
> 
> I can throw together a patch if you haven't already committed one by the
> time you read this ;).

I'm not touching that code except to send out possible patches for others 
to test and comment on. I have no test-cases, nor any real interest in it. 
So yeah, please send me a tested and thought-through patch.

It sounded like Karl actually had a test-case to trigger this, but maybe 
I'm confused (and it sounds a bit unlikely, since it should be hard to 
trigger.. Although maybe you can trigger it by doing a direct_IO write 
with the *source* being an mmap() of the file you're writing to, and 
depending on the write itself re-populating the destination in the page 
cache?)

Karl?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/