Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Jul 2023 19:25:06 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>,
        Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>,
        Fabio <fmdefrancesco@gmail.com>, Deepak R Varma <drv@mailo.com>,
        Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH] Remove unnecessary calls to kmap{,_local_page}() when
 acquiring pages using GFP_DMA32.
Message-ID: <64bde1026a0af_7a6c729452@iweiny-mobl.notmuch>
References: <20230719134314.GA7590@ubuntu>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230719134314.GA7590@ubuntu>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZHMe14Vhi/fXkS3sL3L+XPEYeJzcfYKdyMLmvTb67S/LvLQ/d5XEcEQldi27?=
 =?us-ascii?Q?Fm8wFf10BmnBpinnVosOBX0xA/kVgK4KWgJbeI4BDjvDJWFJkv0RkB0h5LuI?=
 =?us-ascii?Q?XtkCR3haBJO8K2/+oD94h7RRLHGMQMFWAuL1yt4p9Gh/085r4tFnCrx9sAF5?=
 =?us-ascii?Q?2p4kPK8aCpEYcbgkdS5YeknUo4TLaV0fUt1bo4HLlwpmT8yNWmZSB8aSIVUL?=
 =?us-ascii?Q?/2PRCqgXDF2JOJsX4HO2yTZP72i2WVlIqj3SrZLoa+dSTF56h9MGVVYFYK2e?=
 =?us-ascii?Q?0aIqbXW3ty9Haw3FUk6iHX7/nIFSy6sqZcfsXoFQTtHdhmLqIhzEvPjmr2Ky?=
 =?us-ascii?Q?mR8pUF6ONle4jf4KrCkDk/gOmJgfNwU8SB+Mphao6XqGjscon1doHKUPOOfu?=
 =?us-ascii?Q?6n9lWET6l6HHXwEzq7JUpOvRgF33rFEeU1mDbspfqtYIADUA6ScKa9+hDHgP?=
 =?us-ascii?Q?nvcYHjE/4O5A11b7P1dtpbkV54Bh/wWMTiDQMWAjjHOfkmnxD7Hnt5aztg9w?=
 =?us-ascii?Q?FRcYhog4XmT90ZekgoPVud0m92BzgLvez6YvZUoJGvZV06S8NInxC/SIjVBG?=
 =?us-ascii?Q?rcnVcH3uzo1qNd9yGqfTv4C4O0y3eoXf93VwA8GcrD7j6pLg0lTX5Ki9AM5H?=
 =?us-ascii?Q?3RIpCReJTPi9tRxCfNCdpikC4byFgiSGDEiIr2Wx5EwK43XVKdRfEfzU1MOj?=
 =?us-ascii?Q?pCVIId2NmaIEt4xjS1BFpCJByD6cdWz0Kbgl/nfw0ktUxadM9EK5ndv7qZme?=
 =?us-ascii?Q?nEkQvktsPXUDaCJEq421c1pEpWaGQdonvOZPW/rqqwBH5Mn5D2lflew0U9+G?=
 =?us-ascii?Q?KhjoHrhEUnrUVwyfjnsC/Ap5L8SYItHNlwA0KMAzM6NOrCTUVOwUzi2HYglq?=
 =?us-ascii?Q?GwYu8ZZtg8lfC1aax1lrdEdPCuRAQkOwbEI4FXSNirzJ+Z/iGPxxHHUfeSIG?=
 =?us-ascii?Q?J7Bvgp1azIKNWGvKUdLI2FtU6SFPlbKxJzt2ZUG4eaxpN2M/AScQJROnqkQq?=
 =?us-ascii?Q?56f+uERYbCAabk2H2H8MMVUxbBBGgdAWTpQVLP48kqU2kelgJA2HMBQZuxlM?=
 =?us-ascii?Q?WtdxWIJdDDqtjEZgVn7MbsDnDKgUkLkTCnntnz9M4GGY5cmxq9wwjRh8X21X?=
 =?us-ascii?Q?0BkitoxXQ0X0SqGLNTkZC5nsOOUeEYBeJBdOB3oqGObT2fVbO6xJVjqkPbNv?=
 =?us-ascii?Q?QLYrjPueLxy6/+c8dixt9yHGNNFXuTBft8H0SCpd+aRI6NJvBwJFQ4nPku/E?=
 =?us-ascii?Q?nFjIluQukXB55TM/OBL6N8C2bIaTknLOWniN1ZbdTlrAdYHdhU6780AGcmFd?=
 =?us-ascii?Q?QReZpLRbIsLwUEAZEjklzFnCs63xVtbPhAPFh28TV1t40krCP/zJ27v+O6Q3?=
 =?us-ascii?Q?/89Q+YjVejlUTnSsDswoHriDBm0bJHE5kyZ0f/Db0PkMam76Xq4Vqdlpz7oO?=
 =?us-ascii?Q?vxT48MucnvlRSPq93c9oYPaBXYcGbIhcXOZkltgCJmTHE994wJiKC4FXYJQJ?=
 =?us-ascii?Q?5hfhap3d2CUl5bluqClHtp9bBVaXEKeUyi8l01Yw46hugjXzH6I3VxrfyfvC?=
 =?us-ascii?Q?YCeYlqAa+3dlky56hHHpmSP+U2LNjelu+N80GfYv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2f3fa96-5fa5-4e3a-c561-08db8bed33dd
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 02:25:10.0716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xxqJzR5Gcn7iaykXaBSbL9F/5xBEMrPPKoFDcGA2Js7Fgcy+gVYXoXg3RLR8QmjIOLxsYzYWM9m5Hq9NmlR67w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8480
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sumitra Sharma wrote:
> The GFP_DMA32 uses the DMA32 zone to satisfy the allocation
> requests. Therefore, pages allocated with GFP_DMA32 cannot
> come from Highmem.
> 
> Avoid using calls to kmap() / kunmap() as the kmap() is being
> deprecated [1].
> 
> Avoid using calls to kmap_local_page() / kunmap_local() as the
> code does not depends on the implicit disable of migration of
> local mappings and is, in fact, an unnecessary overhead for
> the main code [2].
> 
> Hence, use a plain page_address() directly in the
> psb_mmu_alloc_pd function.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/
> [2]: https://lwn.net/Articles/836503/
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
>  drivers/gpu/drm/gma500/mmu.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
> index a70b01ccdf70..1a44dd062fd1 100644
> --- a/drivers/gpu/drm/gma500/mmu.c
> +++ b/drivers/gpu/drm/gma500/mmu.c
> @@ -184,20 +184,15 @@ struct psb_mmu_pd *psb_mmu_alloc_pd(struct psb_mmu_driver *driver,
>  		pd->invalid_pte = 0;
>  	}
>  
> -	v = kmap_local_page(pd->dummy_pt);
> +	v = page_address(pd->dummy_pt);
>  	for (i = 0; i < (PAGE_SIZE / sizeof(uint32_t)); ++i)
>  		v[i] = pd->invalid_pte;
>  
> -	kunmap_local(v);
> -
> -	v = kmap_local_page(pd->p);
> +	v = page_address(pd->p);
>  	for (i = 0; i < (PAGE_SIZE / sizeof(uint32_t)); ++i)
>  		v[i] = pd->invalid_pde;
>  
> -	kunmap_local(v);
> -
> -	clear_page(kmap(pd->dummy_page));
> -	kunmap(pd->dummy_page);
> +	clear_page(page_address(pd->dummy_page));
>  
>  	pd->tables = vmalloc_user(sizeof(struct psb_mmu_pt *) * 1024);
>  	if (!pd->tables)
> -- 
> 2.25.1
>