Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm/memcg: fix obsolete function name in
 mem_cgroup_protection()
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>
References: <20230723032538.3190239-1-linmiaohe@huawei.com>
 <ZL2Ph5g05Ud5vAdT@casper.infradead.org>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <e3924d13-410c-21e5-b3df-21fea0f45574@huawei.com>
Date:   Mon, 24 Jul 2023 09:52:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <ZL2Ph5g05Ud5vAdT@casper.infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/24 4:37, Matthew Wilcox wrote:
> On Sun, Jul 23, 2023 at 11:25:38AM +0800, Miaohe Lin wrote:
>> @@ -582,9 +582,9 @@ static inline void mem_cgroup_protection(struct mem_cgroup *root,
>>  	/*
>>  	 * There is no reclaim protection applied to a targeted reclaim.
>>  	 * We are special casing this specific case here because
>> -	 * mem_cgroup_protected calculation is not robust enough to keep
>> -	 * the protection invariant for calculated effective values for
>> -	 * parallel reclaimers with different reclaim target. This is
>> +	 * mem_cgroup_calculate_protection calculation is not robust enough
>> +	 * to keep the protection invariant for calculated effective values
>> +	 * for parallel reclaimers with different reclaim target. This is
>>  	 * especially a problem for tail memcgs (as they have pages on LRU)
>>  	 * which would want to have effective values 0 for targeted reclaim
>>  	 * but a different value for external reclaim.
> 
> This reads a little awkwardly now.  How about:
> 
>  	 * We are special casing this specific case here because
> -	 * mem_cgroup_protected calculation is not robust enough to keep
> +	 * mem_cgroup_calculate_protection is not robust enough to keep

Sounds better. Will do it in v2.

Thanks.