Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 13:55:13 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Rob Herring <robherring2@gmail.com>
Cc:     Frank Rowand <frowand.list@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] of: fix htmldocs build warnings
Message-ID: <20230724135513.3773f184@canb.auug.org.au>
In-Reply-To: <20230713161038.382b5e14@canb.auug.org.au>
References: <20230220163638.04e9d0c4@canb.auug.org.au>
        <20230310113258.463f836c@canb.auug.org.au>
        <20230322180032.1badd132@canb.auug.org.au>
        <20230713161038.382b5e14@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/1a4j_oBF+fVe6xjvNiDxNmv";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/1a4j_oBF+fVe6xjvNiDxNmv
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Thu, 13 Jul 2023 16:10:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> =
wrote:
>
> On Wed, 22 Mar 2023 18:00:32 +1100 Stephen Rothwell <sfr@canb.auug.org.au=
> wrote:
> >
> > Fix these htmldoc build warnings:
> >=20
> > include/linux/of.h:115: warning: cannot understand function prototype: =
'const struct kobj_type of_node_ktype; '
> > include/linux/of.h:118: warning: Excess function parameter 'phandle_nam=
e' description in 'of_node_init'
> >=20
> > Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node c=
reation functions")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  include/linux/of.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >=20
> > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > fixes the new warning about phandle that Randy reported.
> >=20
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9b7a99499ef3..d55dab9ad728 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> >  	struct property		*old_prop;
> >  };
> > =20
> > +extern const struct kobj_type of_node_ktype;
> > +extern const struct fwnode_operations of_fwnode_ops;
> > +
> >  /**
> >   * of_node_init - initialize a devicetree node
> >   * @node: Pointer to device node that has been created by kzalloc()
> > - * @phandle_name: Name of property holding a phandle value
> >   *
> >   * On return the device_node refcount is set to one.  Use of_node_put()
> >   * on @node when done to free the memory allocated for it.  If the node
> > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> >   * whether to free the memory will be done by node->release(), which is
> >   * of_node_release().
> >   */
> > -/* initialize a node */
> > -extern const struct kobj_type of_node_ktype;
> > -extern const struct fwnode_operations of_fwnode_ops;
> >  static inline void of_node_init(struct device_node *node)
> >  {
> >  #if defined(CONFIG_OF_KOBJ)
> > --=20
> > 2.39.2 =20
>=20
> Any chance if this patch being applied?

Is there something wrong with the patch?

P.S. Rob, should I use your kernel.org address as your linux-next
contact?
--=20
Cheers,
Stephen Rothwell

--Sig_/1a4j_oBF+fVe6xjvNiDxNmv
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmS99iIACgkQAVBC80lX
0GwUjgf/ZLyWdLI8NGli3RmCOslcvCkMO1wrOinImDrfrn5yZnstdgdBmNUObUTD
4Xghp0pi6sbYyn4WVBuf3JKL4XrPMt8rJ47O4Nid8PcKfbsONDgIhRlbWBNHRHM5
PGvNuMMSr9/M4qNFCFDe2D1XLa5HouiTOGVNw+sR0fBkOBu7UHawNmC1PrBn+zcv
voCgjQbL9J1Czmpresx8q8H/Oz+apSVSv5xpOb3REFsmvt2Xih3xal00iinS9o53
ZbmMkDyUUjt9O85XM8LXTCJhL3j39c5NDCW0Bz+eh+VugL0T+24Ky+JnzoPKTx5V
gyy6QSd0ED+tYp5jfWJzZNpTC4swwg==
=R8n4
-----END PGP SIGNATURE-----

--Sig_/1a4j_oBF+fVe6xjvNiDxNmv--