Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2697099rwo; Sun, 23 Jul 2023 22:50:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlF/+i0sfo7XcbVEjE9FJ16PfpvzyKV1wkJZJ9hJiWQSktHYCqT+jnBkX+XaqD2yPf4r2BfU X-Received: by 2002:a81:8606:0:b0:57a:5b6f:ce3 with SMTP id w6-20020a818606000000b0057a5b6f0ce3mr6170950ywf.44.1690177854024; Sun, 23 Jul 2023 22:50:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690177853; cv=none; d=google.com; s=arc-20160816; b=do5XEKTpnXz3qxegM2ThJ+xc8TCeSqdqq4P9SGXNba+inWaq3Xu5MeoNnn2XA2x7WV CTJK3oT8hHseP6MCMIrP0BCbcOZz/HUxRIxga6P9/o7kv/P3tASeCJAl2x2T+YsRaAJ2 0JEzzW8IIw1UFiM3RRpZNBFPa0+s2rXAYy7R0HvIXLw/B8tv/Weqr90SAmQWhx1E3d4d ndj+KmAFMwNUgIcrjiSh7ag3tXDNe/XNwOZY9a4S3N9Ezi0EkWmUypqRQkVQnGR4sCvV F0T3ifC/HZMWKo6NKR8vJpdNFX0N1cPO3/JwRB+zaoKRXwLl+IkCm18s1PaLzXStzjXV N+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9I8o7ui699KPf1qkPwqntM7BfAFxPVv36DmC3afsxzw=; fh=p8MUrHyPGwgAA9AJjPgaugOdbB30usLfAyRD2VeEGb0=; b=ayFmuDFHNNmS/iIMTcV0DWPzyLDAu6BsRV0y5MPnhG6Vs5hUFwQdHmwgYY5gT5NgSx KHnlz5zp5oSuuU7YAa20y1JgBukYh3jdjai8+qO5Qsb0Fsceo3loX27SQx0rREFfZWkm NPOjApjTT94a4OvAvSp2cExhlbaLE/NIk6B0VZ5zXTbfbkPkq8OXLwYqu+1UDBY5wYsz RijRoepevFHFTMHhFoeWUyP+gePECKM/6kmpNKTSeR71ADqOL87faVdAP7PqsWaPtivp t43nJcXvLuLpIxutm8KVqZh7DMuNqJ2LJrlN/db5qfZOP0Xa3Aowq9mDKxoIyWziKuts xg6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=dlEExe2D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id my14-20020a17090b4c8e00b002680dba282csi2763611pjb.182.2023.07.23.22.50.42; Sun, 23 Jul 2023 22:50:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=dlEExe2D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbjGXFcp (ORCPT + 99 others); Mon, 24 Jul 2023 01:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGXFco (ORCPT ); Mon, 24 Jul 2023 01:32:44 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DC14109; Sun, 23 Jul 2023 22:32:43 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-66869feb7d1so2205746b3a.3; Sun, 23 Jul 2023 22:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690176762; x=1690781562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9I8o7ui699KPf1qkPwqntM7BfAFxPVv36DmC3afsxzw=; b=dlEExe2DT/Ks5BInMo/+rOPYOzDbq7d77fWeZCpd0iu0z6HhpmiDHGsnJYYCCLcEpR dlp87JZs/TnaD5ZoUMP4sSSW20V/3Dd78l9pyfsBErem2MeLq0vNbfIub8DDz2XisnD+ zkn/4VyE5oWb6xfA9lHV5/IF+HV0QG6rA+15+wfe2Ifn2D8CKMpDNMJ0ES0uVMcvX/ki VA5MqG7129UUiMoszqIHWR1WmVK1+MyBKbUCkY89YlxebQUCas1lgFN2GPWHkXL3K4Db r6+ghq+cCAni5vMdFYtcbVKWyps2bNMu/udTtb7mlbh2NMWKJWCri9M/PmBmNa9Z5sLq M6Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690176762; x=1690781562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9I8o7ui699KPf1qkPwqntM7BfAFxPVv36DmC3afsxzw=; b=ak/Sxspv6V5N4LPIj2bg17CpEs7vZdrp7JTP3+MzP78WDNxHm+6SlrRrlRd4Dk08eH P6PcskpMSWKNA6N5RVgtHQgy6GW90y8ziGY4D/TxWT5kK16ranEYLueh7QdigLdWgReC TIikN0aFh9L+fbGbiimSPPMtULqwFmKAxIgmPZ+8sByvt7JQnc8kS9hgJJWQdglwwEDn oEjqDWe8T+kfJeUY7EdGFgIMHkif6RPrrJLq3yUK30rwd+ZeiTw70hBdIsvjGTeYYr4u MNYj7910zPDqFn46R8/53vdU2J8fFOdmmz0CSHetKt+DfOvAL6C+/eNU6n3CbYde6H2v /cng== X-Gm-Message-State: ABy/qLbKcQXYRrAt8G71E2Y1hKe97trrF7CANlSCDK8y+2uwV9pFDsHl 7Z23GcZzsdkUoDrtaJOm1yQ= X-Received: by 2002:a05:6a20:186:b0:137:7198:af9b with SMTP id 6-20020a056a20018600b001377198af9bmr7573651pzy.56.1690176762563; Sun, 23 Jul 2023 22:32:42 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:b8db:3c3:1ff4:2ae3]) by smtp.gmail.com with ESMTPSA id s10-20020a170902a50a00b001b8307c81c8sm7837884plq.121.2023.07.23.22.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 22:32:42 -0700 (PDT) Date: Sun, 23 Jul 2023 22:32:39 -0700 From: Dmitry Torokhov To: Yangtao Li Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] Input: lm8333 - convert to use devm_* api Message-ID: References: <20230714080611.81302-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714080611.81302-1-frank.li@vivo.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yangtao, On Fri, Jul 14, 2023 at 04:06:04PM +0800, Yangtao Li wrote: > Use devm_* api to simplify code, this makes it unnecessary to explicitly > release resources. > > Signed-off-by: Yangtao Li > --- > drivers/input/keyboard/lm8333.c | 40 +++++++++------------------------ > 1 file changed, 11 insertions(+), 29 deletions(-) > > diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c > index c9f05764e36d..41d088933e01 100644 > --- a/drivers/input/keyboard/lm8333.c > +++ b/drivers/input/keyboard/lm8333.c > @@ -129,6 +129,7 @@ static int lm8333_probe(struct i2c_client *client) > { > const struct lm8333_platform_data *pdata = > dev_get_platdata(&client->dev); > + struct device *dev = &client->dev; This temporary is used only in few places, while the rest are still using &client->dev. I removed it, made a couple more changes and applied, thank you. -- Dmitry