Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] m68knommu: Fix warnings in io_no.h: Delete one of
 repeated word 'readw readl writew writel' in comment. WARNING: Possible
 repeated word: 'readw' WARNING: Possible repeated word: 'readl' WARNING:
 Possible repeated word: 'writew' WARNING: Possible repeated word: 'writel'
To:     huzhi001@208suo.com, gerg@linux-m68k.org, geert@linux-m68k.org
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
References: <tencent_816D5035481D1083943D8E965A59860D5E06@qq.com>
 <9e13fec02524afde21bdf5783dcf7246@208suo.com>
From:   Michael Schmitz <schmitzmic@gmail.com>
Message-ID: <b0c9bf6d-786d-29b8-7811-e132534227fe@gmail.com>
Date:   Mon, 24 Jul 2023 17:34:34 +1200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <9e13fec02524afde21bdf5783dcf7246@208suo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

please reconsider - "#define something something" is legitimate use, and
quite intentional.

Pattern matching can only get you so far, sorry ...

Cheers,

    Michael

Am 24.07.23 um 12:40 schrieb huzhi001@208suo.com:
> Signed-off-by: ZhiHu <huzhi001@208suo.com>
> ---
>  arch/m68k/include/asm/io_no.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68k/include/asm/io_no.h
> b/arch/m68k/include/asm/io_no.h
> index 2c96e8480173..b24eb741e666 100644
> --- a/arch/m68k/include/asm/io_no.h
> +++ b/arch/m68k/include/asm/io_no.h
> @@ -62,7 +62,7 @@ static int cf_internalio(const volatile void __iomem
> *addr)
>   * endian on m68k/ColdFire. Bus based address ranges, like the PCI bus,
>   * are accessed little endian - so we need to byte swap those.
>   */
> -#define readw readw
> +#define readw
>  static inline u16 readw(const volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -70,7 +70,7 @@ static inline u16 readw(const volatile void __iomem
> *addr)
>      return swab16(__raw_readw(addr));
>  }
>
> -#define readl readl
> +#define readl
>  static inline u32 readl(const volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -78,7 +78,7 @@ static inline u32 readl(const volatile void __iomem
> *addr)
>      return swab32(__raw_readl(addr));
>  }
>
> -#define writew writew
> +#define writew
>  static inline void writew(u16 value, volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -87,7 +87,7 @@ static inline void writew(u16 value, volatile void
> __iomem *addr)
>          __raw_writew(swab16(value), addr);
>  }
>
> -#define writel writel
> +#define writel
>  static inline void writel(u32 value, volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))