Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2717205rwo; Sun, 23 Jul 2023 23:18:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlHzju0W2ybPGE8xVtJExns0eHXGWMRRb4nW+wXOmYHSRnu3cA3xBzuBCpo8TTkIT/6t9Cke X-Received: by 2002:a17:906:2012:b0:992:d013:1135 with SMTP id 18-20020a170906201200b00992d0131135mr8087613ejo.63.1690179530209; Sun, 23 Jul 2023 23:18:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690179530; cv=none; d=google.com; s=arc-20160816; b=IgC9SFkIzTtXN8pjB7wj9vutNJvVKkkGVaUpRLqBztVwfhgaRXOJjijZvyKMNZk5Nq Uu1mE8FN/b3iAlDfxmq8MmdwIC+goZ3GEAy+/3s5el9G+bquqU5mf7Oc+Re/ZK1tqS8W JNNZeyEtfm7lLwovrguLBliqsLOfz1nwnb5qwVMB37aTCYtYHzCNxLzgLEh3UvX019iC 8VUuMpGMdO6q7KH57feWgnIORFzJFIMe98yHEj/Iw8xrpYDcyPEU/e0WyhxZWiN1w55p CKZylXXJMBvh1zkfdniInaBCy05f8PMZEveTDogypJnZYZCDTc1TZFnF6cJJPt8lfg1y DeHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0O+zqek4aroJ1gaWng0knQ8HoCxw3ZVY5JHWSMFwAtU=; fh=p8MUrHyPGwgAA9AJjPgaugOdbB30usLfAyRD2VeEGb0=; b=f5oXsAfY+lCo2r/wqnfKnAJYwDUCZQ/+a+yN6YODoDS4TsUnAyA8re6lLUGs/lKWTr H5Qc7NwSlwRZD9qwvbAI9iYC6orLaBq3GmXgSoql+ZHahy9H9Nn7pKm6LG9FxEfqyoPu BMQFibOKVmx1Fztb+58+s3qeoxwQuAfzIfthiHt/1nyhwhmbxUYJ6Js8e5v+K9WuPdY4 yWRZWZv+14uXRLtumSTbkqTEkqi9th4I5s8sYnQ7bjC/huWTGANExO5tUrvK1vqcKHS+ ipwgEKh+j7SR7JEl/qURD6oRobSeIeipyT+Ymc/+5u6e7kBEp28IL6oQCxExSWCsL5D3 tSfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=V5iIIvaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a1709067c5500b00992f1a3b9d9si5805303ejp.415.2023.07.23.23.18.26; Sun, 23 Jul 2023 23:18:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=V5iIIvaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjGXFil (ORCPT + 99 others); Mon, 24 Jul 2023 01:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbjGXFik (ORCPT ); Mon, 24 Jul 2023 01:38:40 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD48186; Sun, 23 Jul 2023 22:38:39 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-666eec46206so3791429b3a.3; Sun, 23 Jul 2023 22:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690177119; x=1690781919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0O+zqek4aroJ1gaWng0knQ8HoCxw3ZVY5JHWSMFwAtU=; b=V5iIIvaLLIEztxm5S+YYwfPN5wg0VLDo1I6RESsGPoo0ESNcUmJ1LGW2NVgteYkC9S JTKhzh6GRg1DEnQD70+0fhZbul9duRaM5zxbC0PonYj5swp6BYTLmE+u9z7J48BOorQ8 k8VcrteNBDizPHaOHGZ3Ckv7hU6u4B1YS5Iw130TRCnThip85gGIG6nB9u1DJpL04LHd 6Vm/jiGDFzOx3P+7TZllGzp6rk0o3pSwGRVbJ1zftygcdpSV3ZQBFEWIS0lXvQbzeUdc j+bJimf5YZY9eGUf62CZcE2BRuadlkWK/zvnuHPlO0iYa8XTFLrxkTxgWsrFDHFwgTcw GLQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690177119; x=1690781919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0O+zqek4aroJ1gaWng0knQ8HoCxw3ZVY5JHWSMFwAtU=; b=fuE1KuaqTMouzw0aVHeNikdV9rWRPTWj8x4PbSXhrVc819cUhCTB8V8PeBbnBrh+OA bGPwy3UCBOVwcBMdfx9o7LzEv5VMae9PtQjxNIJAh/MwfT2hggDfbNTW5r+MttKC5kM2 s7BsKrBQ+FsUuc/2LjJrCR/wcxMUrbdS3j0I/NlQKgZr+JS7fNW7HDxBAD2kLyGWgHTe La95mDCvWPoifOhazSY8x1uboV/0evbsb8eTLSNfn6wFKAXgKpn+yQhQlgOrKTbfyJtw Bm2mz4FAcaXXaVNziBFdNsQtnM5Vv6bkXDlG6H7haK/awcwVHe6fJHeJvZNdj/S3Yb+2 XQYw== X-Gm-Message-State: ABy/qLZ0Jcj1nTiS7MZEo0/n4M6zjyoWQ7hofy1jDvfk4CcDM8OJabHv awmSUZ6vsbQglC8pVuoiZTAcQwHbIS8= X-Received: by 2002:a05:6a00:230e:b0:66a:5d4a:e47d with SMTP id h14-20020a056a00230e00b0066a5d4ae47dmr10191222pfh.8.1690177119130; Sun, 23 Jul 2023 22:38:39 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:b8db:3c3:1ff4:2ae3]) by smtp.gmail.com with ESMTPSA id c5-20020a637245000000b0055386b1415dsm7569587pgn.51.2023.07.23.22.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 22:38:38 -0700 (PDT) Date: Sun, 23 Jul 2023 22:38:36 -0700 From: Dmitry Torokhov To: Yangtao Li Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] Input: tca6416-keypad - convert to use devm_* api Message-ID: References: <20230714080611.81302-1-frank.li@vivo.com> <20230714080611.81302-4-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714080611.81302-4-frank.li@vivo.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FSL_HELO_FAKE, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 04:06:07PM +0800, Yangtao Li wrote: > Use devm_* api to simplify code, this makes it unnecessary to explicitly > release resources. The driver needs bigger facelift; I posted a series addressing this that incorporates your patch. Thanks. -- Dmitry