Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8e9164fc-2276-e6b8-a4f6-c0c025bd6b86@linaro.org>
Date:   Mon, 24 Jul 2023 09:17:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding
 doc
Content-Language: en-US
To:     Pankaj Gupta <pankaj.gupta@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Daniel Baluta <daniel.baluta@nxp.com>
References: <20230616181144.646500-1-pankaj.gupta@nxp.com>
 <20230616181144.646500-2-pankaj.gupta@nxp.com>
 <a06dbb80-c9b2-3a57-cbc5-b18432b4029a@linaro.org>
 <PAXPR04MB8638D1504946559095E1CAB69530A@PAXPR04MB8638.eurprd04.prod.outlook.com>
 <9dd411e0-6cc5-44c1-be56-ecb2ad809a9b@linaro.org>
 <DU2PR04MB86309B90B0849AFB23F6462F9502A@DU2PR04MB8630.eurprd04.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <DU2PR04MB86309B90B0849AFB23F6462F9502A@DU2PR04MB8630.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/07/2023 08:37, Pankaj Gupta wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Thursday, July 13, 2023 12:12 AM
>> To: Pankaj Gupta <pankaj.gupta@nxp.com>; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
>> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Gaurav
>> Jain <gaurav.jain@nxp.com>; linux-kernel@vger.kernel.org; Daniel Baluta
>> <daniel.baluta@nxp.com>
>> Subject: Re: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding
>> doc
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 10/07/2023 19:52, Pankaj Gupta wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Sent: Friday, June 16, 2023 6:51 PM
>>>> To: Pankaj Gupta <pankaj.gupta@nxp.com>; robh+dt@kernel.org;
>>>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>>>> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
>>>> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
>>>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>>>> Gaurav Jain <gaurav.jain@nxp.com>; linux-kernel@vger.kernel.org;
>>>> Daniel Baluta <daniel.baluta@nxp.com>
>>>> Subject: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu
>>>> binding doc
>>>>
>>>> Caution: This is an external email. Please take care when clicking
>>>> links or opening attachments. When in doubt, report the message using
>>>> the 'Report this email' button
>>>>
>>>>
>>>> On 16/06/2023 20:11, Pankaj Gupta wrote:
>>>>> The NXP i.MX Message Unit enables two processing elements to
>>>>> communicate & co-ordinate with each other. This driver is used to
>>>>> communicate between Application Core and NXP HSM IPs like NXP
>>>> EdgeLock
>>>>> Enclave etc.
>>>>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
>>>>>
>>>>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
>>>>
>>>> I don't see reply to Daniel's concerns.
>>>>
>>>> I don't see improvements here based on the previous review you received.
>>>> It seems you just ignored everything, right?
>>> Replied to Daniel's concern.
>>>
>>>>
>>>> Limited review follows up because binding is not in the shape for upstream.
>>>> Do some internal reviews prior sending it.
>>> Done the internal review.
>>
>> I doubt. Your v4 bindings and DTS were not tested. v4 Driver has trivial issues.
>>
> It is tested and my driver get probed. And all my functional tests are passing.
> No Patch-set is sent without testing.

As you explained there, you did not test the bindings nor DTS with
dtbs_check. So your test-suite is incomplete, it lacks basic testing.

Best regards,
Krzysztof