Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2828924rwo; Mon, 24 Jul 2023 01:43:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlHDoezpknOA3/p6sgcuTg+odUor9kZop84ys4Q9iZQiXreHCsU7m1bSJ09Z1xhxt7/1ty/5 X-Received: by 2002:a05:6358:9494:b0:129:df95:f9a9 with SMTP id i20-20020a056358949400b00129df95f9a9mr4257710rwb.2.1690188214688; Mon, 24 Jul 2023 01:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690188214; cv=none; d=google.com; s=arc-20160816; b=x/jfQgACuzltkDbVnGNw63NMoRObKNG+j4eHACFdYwVwYyqHUv90f/lGqElU/s7a4b sSidoWZsSADA9HRBTtsJQfqyoDKbkFpfQc+QVUR6YgJ9GHyNqKKydBYeaAu196PjUrzX Ae+2vmS7T3Bnt1u23snVtymy9tvjUVOSCxsbXoih9A1cRt1bwUeDk+5cxvWmUenkXD4f dj1Rhpq0yjqJ432kAF6IgbA3mba1eu5tpdtp+DSH2AMzj6xdfe+m/8470Eg2kEhBUDz+ IG+rEroUCB4ILXynTRxbM+XfhGRHAj9V4cnkJeJSscSMhSvrlG3x25yzlnDqW6QnONI7 hvnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y2VAJOXdaFV2hBUjfOiEb1JKHvdtTH9w2oKNLvsuEOI=; fh=qB36wD5VviBFC99o98caOyFwWHrkOVNtyQy86K8r8II=; b=G2kuopNphu+A5veBDMen436iDeS4kUW3/8Oad7oDuntiDp99jV5OqSciSR1rb8Od+W ul11gCj14bpKpzRiQlXDdyL3dxNGg7Zp6XObE2TwrEw22Y2FpLk8/ftCaMP+787qYuDy AM9eRGpF/EYMbT8IyIqFUFutT93IpI633ZLRabuMiMAQVoODdxp4XiM9PjynjOtsmk3R EvOzpFF9AQPDx8A9LnFvVb8iZgYu1Foh+zE3YmD+RkJco9CuNpcVFjqDmm7z5A0lf1u+ /Vv3xMSOJCpeUDKQzL6D1tdqLSvwW2Vf9kX0QYKExMJ789l1ny5OfJD/nznV52hfQKt1 gf1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uB9tusxW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c124-20020a633582000000b00563b6014700si1605964pga.515.2023.07.24.01.43.23; Mon, 24 Jul 2023 01:43:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uB9tusxW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbjGXIR2 (ORCPT + 99 others); Mon, 24 Jul 2023 04:17:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjGXIRG (ORCPT ); Mon, 24 Jul 2023 04:17:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A314BE40 for ; Mon, 24 Jul 2023 01:17:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D88260FB5 for ; Mon, 24 Jul 2023 08:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E5A5C433C8; Mon, 24 Jul 2023 08:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690186624; bh=Qi/DymkSC6mDUS+3IIFJJcXGnZB5VSfohCNuw53J69s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uB9tusxWtz2OC/IP+hp4pJTgoKnHXbz0Cv10cctchAB7XGxmXhWbaRW/VkAHr4Nzr NtKlx9d9REjD3ytXyfGZITZXCkDegadwn/pykN4AUIGZeee7JlG8RWJdW1wJOZHPfo j66WB7tbUntSL/YVboQ2a/NwaCbeQjm6S4FdZ4UP6QiucXN5YjorCysA6qqCGP2NlC El7aokJc3Wj6A7MI8HpMnWP/Ainxq6XrfZm43eNgWC7raE4ZyVQyRqmIbbWpeRtli6 w6qrWRjw80cJlN7OgTv+bDpVrqaEMd8YY0xp5KXYfZCvcdXP0750pACYbVW1wteCis 8pmr7cqYg2A7A== From: Robert Foss To: AngeloGioacchino Del Regno , Xin Ji , Chen-Yu Tsai , Andrzej Hajda , Laurent Pinchart , Neil Armstrong , Jernej Skrabec , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Jonas Karlman Cc: Robert Foss , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org, David Airlie Subject: Re: [PATCH v2] drm/bridge: anx7625: Drop device lock before drm_helper_hpd_irq_event() Date: Mon, 24 Jul 2023 10:16:56 +0200 Message-ID: <169018660964.606978.4469347765082724733.b4-ty@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710085922.1871465-1-wenst@chromium.org> References: <20230710085922.1871465-1-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jul 2023 16:59:21 +0800, Chen-Yu Tsai wrote: > The device lock is used to serialize the low level power sequencing > operations. Since drm_helper_hpd_irq_event() could end up calling > .atomic_enable, which also calls power sequencing functions through > runtime PM, this results in a real deadlock. This was observed on an > MT8192-based Chromebook's external display (with appropriate patches [1] > and DT changes applied). > > [...] Applied, thanks! [1/1] drm/bridge: anx7625: Drop device lock before drm_helper_hpd_irq_event() https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f2cca20f1fa3 Rob