Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     "Li, Xin3" <xin3.li@intel.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Brian Gerst <brgerst@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "brgerst@gmail.com" <brgerst@gmail.com>
Subject: RE: [PATCH] x86/ia32: Do not modify the DPL bits for a null selector
Thread-Topic: [PATCH] x86/ia32: Do not modify the DPL bits for a null selector
Thread-Index: AQHZr83AFvT4TTcrIkq3d3Abr5XF0q+sxk7ngAC/myCAAC0zwIAA3mCQgABOVsCAAAwbN4AAax4AgBlVv/A=
Date:   Mon, 24 Jul 2023 08:54:49 +0000
Message-ID: <SA1PR11MB6734633D2D745D3FE9A670F2A802A@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230706052231.2183-1-xin3.li@intel.com>
        <87v8exgmot.fsf@email.froward.int.ebiederm.org>
        <SA1PR11MB67348D11385F584354AB84C3A82DA@SA1PR11MB6734.namprd11.prod.outlook.com>
        <SA1PR11MB6734F3F72095C4D6B9C12C9BA82DA@SA1PR11MB6734.namprd11.prod.outlook.com>
        <87sf9zfx76.fsf@email.froward.int.ebiederm.org>
        <SA1PR11MB6734577080AC6734E305D735A82DA@SA1PR11MB6734.namprd11.prod.outlook.com>
 <87pm53e3ne.fsf@email.froward.int.ebiederm.org>
 <SA1PR11MB6734547F70FAFC9297D89F7BA832A@SA1PR11MB6734.namprd11.prod.outlook.com>
In-Reply-To: <SA1PR11MB6734547F70FAFC9297D89F7BA832A@SA1PR11MB6734.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vjrjpjsIb9na+cZjpplpJitHEnbwYCt6iNgAI7TUhANpBkONCsf5CnE1L/Th?=
 =?us-ascii?Q?sdhdhS8ncgm5sh+1Rvv+bWZfzOrtTapm6/hK046HZBgTPYjjJKpE0YlTzaVx?=
 =?us-ascii?Q?l6TZVkZa9PKKm/0nNgyp1PNN1uST2yRQU9TP3oM8Vp8kMeivy6PTek1o7Yax?=
 =?us-ascii?Q?w4L0UjI7+dLKQG5s6rPhARmOEVSMp/h+Yb1+a46Aj9qiWb/4gheTcEsA6Yfs?=
 =?us-ascii?Q?msTMJVRzlsne1JvRhboFdd1BNf93OzJ+eYIz1FhHhD2oNiEfG/KbvH+z4VZG?=
 =?us-ascii?Q?GCne34WBAtpKXYnw5iGJ0jL1dU3BqwuWNYlDmglxfRdBlz3wGFnTUb23NaIV?=
 =?us-ascii?Q?kONRmOE/NV+prz07jXxtaCuJic909j4hIOqPO/iF0Ljca+zw0KMC7DV9OvHZ?=
 =?us-ascii?Q?Azzk9s+GsJ68JdMhgS39Lh/ycAAgV6bTPMYWYMvuxSRDmkVpxl8SbaTBqOt4?=
 =?us-ascii?Q?25iQtw/r8mSI0yJG6WZRbKKKkb9K/ddKRhfpukJmTS8iLccXVLRSnXgFfVRj?=
 =?us-ascii?Q?fkDnBJ6oNbVSaJm8+4B7vjAEzYqzzSwSXoZg8Nu5HCaZIHbGVjqxiMYmRMWe?=
 =?us-ascii?Q?mYJxGyhR+EX+uLi3gM3xHnU0SX/GxuoMYjn06Ulgzsgxe2Xa5ghda+Qckg7M?=
 =?us-ascii?Q?aicU0qu9iFFisFpsy+fIGGnNvpWGUeuzKjrkyl1gVJG0f8QVOTYKB2jdb/Tn?=
 =?us-ascii?Q?9lYJQPmuVVqoo8smTpmWmtuYZuvskRqWiSTjEuq7kf7ct4V3kBsVs4J/OUvQ?=
 =?us-ascii?Q?3RoFzy30YAf2tbnjKiohR8s8p/FuqPRe3OsGORPZ4EDqEfkbOiGvyoi0qEDS?=
 =?us-ascii?Q?4Xh1GDVBl40jtYxGqDpGeirlzhwiRwtioEqoCTpsDwXfbAkt6DyEzOn2/2Ev?=
 =?us-ascii?Q?vwDE5w6Qda4iYVCUMvABPanH5TwfZUoStI1Vl8aMLp8Bg3g/epBQIeUnj7v6?=
 =?us-ascii?Q?VIOd1wV+lnVJnJsH/la30VXxrLxNvz4v5FDaPyLuInsG60LaFOIAs16mbgBO?=
 =?us-ascii?Q?oLkPQfMUGm8TvKxWg6NDTF+zaptAAGb/2v2GOFOI1uFwP02mXh5DtWLAUbIw?=
 =?us-ascii?Q?3BfNJ2h5Jpx16N4wdT3XhshMyIl7xfGFM8+/+kanjbtbcgD/7y5dBWCjL53G?=
 =?us-ascii?Q?bKEXO7krsXr1+ehhKnWMSNJaRjHLvqTsvEaWL+reiNqnv5SUTYDCJcIMfexe?=
 =?us-ascii?Q?ybIiYKLquusGDcZW0u/z7LEFnYS1MrzNWf/LHVseQzmuBx5RzL9FN5rFMZ0r?=
 =?us-ascii?Q?oFhSwAu/norxN+ZJWewOzOuhgfF/VjSrkcfENeRjBOTVBWaWQl1peNjCzT0n?=
 =?us-ascii?Q?/Hglre+RlnXWq9smIpaJxjmGvJ+Zm9jmG4qZPTSuuI1CcSZ1Pl6z3xzn91t2?=
 =?us-ascii?Q?zDCC3oeLoqI7a4nN1Oj5CLQFbS3rxVboCBij3y0Lm2dUFtmi4O0r+sJCocmb?=
 =?us-ascii?Q?pmP1ARkBdPxkKOqbzWxRmJm6jmFFhDusFB7Iq0KqU6papRrjvYfNQn44U8lJ?=
 =?us-ascii?Q?UoLTP2aRE8bW/8UsvL2oJjNylWJdH2GRoYG1W0ABZhDfL0fcDpg+gB5JRdjH?=
 =?us-ascii?Q?3VuWZrylA9fBkUec5qM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3230dc16-a48a-4368-e7b8-08db8c23a366
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2023 08:54:49.5743
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mr7nWOk/isCwpMyNWynHyDueVKfqgSgtLS3U0eFtNQ3X7cXOr/7qyGLEHoyXtdQR7JQXhc7zISI0FxBYxK/xkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7293
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > It bothers me that the existing code, and your code as well only
> > handles the normalization on x86_64 for ia32 mode.  Shouldn't the same
> > normalization logic apply in a 32bit kernel as well?
> > Scope creep I know but the fact the code does not match seems
> > concerning.
>=20
> Agreed! We *should* fix it in the same way.

The fact is that the existing code unconditionally sets the DPL bits
to 3 only on x86_64 (why did we forgot to do it on 32-bit?). Thus,
there is nothing to revert for null selectors on 32-bit.

With your suggestion to normalize null selectors, we need to add the
code only when IRET is NOT used to return to user level. Fortunately,
Brian Gerst just posted a patch set
https://lore.kernel.org/lkml/20230721161018.50214-1-brgerst@gmail.com/,
which makes the case whether IRET is used or not explicit on both x86_64
and x86_32. As a result it is straightforward to add the normalization
code afterwards.

Thanks!
  Xin