Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2861691rwo; Mon, 24 Jul 2023 02:22:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlHky0oFDGi7mAzEGqMrb062PAEHEhhyieFxlLpyjfI42YhSXfV07nJqeZnVCUsg4JKdRG7f X-Received: by 2002:a17:906:1010:b0:99b:5574:7d0f with SMTP id 16-20020a170906101000b0099b55747d0fmr9045709ejm.23.1690190574214; Mon, 24 Jul 2023 02:22:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690190574; cv=none; d=google.com; s=arc-20160816; b=QSGLPbVbz4FJCZSI2jogFYkttFGKklsjGmC/gMjYCho6TUTGFAhTE0gLXfXt8CAQWw fCBszzcANdBRa/+F1NOlB9cGTcUdYtX3IdAtMQxPnJ4y8jn+leR2D9zp4uxVcGsOdwKU sZJgSzB6qmJT8TQO3rUo26f60YN2aZO5zmgwg8S033VeWNLlH3JqxmePxuJKtgjXAI79 TjOTSwLwjlALeU8eUvm0bmlW667KmtT1OPVD3OPAypnZxFNLJCSdpA3Yjmnv/9nLaovh zRbKxnop8TViXAssuMjm/HqdhaFzcEY28hhMHtyMwvJw/5Ydo99CJ+CgfGDBzyXaA2YT M07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5JQk2NKdWBvFJjD1Z6AQyNopYN19Jh6TV7RXwvL6+vo=; fh=Q8R+ocd/vgHKVj+9bIsTNH/I3rxIMnxaWZN6p4yi3U8=; b=aF3RhFdyR7ukfsa/SAmU46bqbkK593dFpweb3YCQ7R7ZEkeW4R04uMdnNrIqtd+IDd h2KGXD2NqQvkwy9e6U2Mu5pzOt/wyVFq5GymZ896kPePsswA0lTeZ9pfav3EmyinXxiT dNzsbRkiAb3xnDfZ65+jyta+5SsHog2ewsFXSmvXKVDf+BcoDgnarUf7q7pQy+mIBr5O pVXk+6tPdHiPXOUUBHuJykYzThiL3lUzXdb50q11U+/3QPizqZt2iLQhMMIlzf//R8uC P/UlwEZ1NcfoS7evm+252PgJUiHhnkRX+TJMlC33n2oRHFlH3UpToZQUrz34bu6XMH1B SJvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=A97+HbW4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a19-20020a1709066d5300b0098debb6fa67si5935455ejt.495.2023.07.24.02.22.29; Mon, 24 Jul 2023 02:22:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=A97+HbW4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232023AbjGXI4m (ORCPT + 99 others); Mon, 24 Jul 2023 04:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231982AbjGXI4f (ORCPT ); Mon, 24 Jul 2023 04:56:35 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8659AE77; Mon, 24 Jul 2023 01:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690188994; x=1721724994; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/Sanj8x3txkk1MfhvdUrm4JxfTPXk0pxg4AntIVUl48=; b=A97+HbW4kBEW+rsL2KD3F1RVeLHc6Jw3lsQPXO1Z1ulH8AYfG9u8/e/V DO1F6d6m3M96Mysj9DiMHQOVa3kOD9jheQ6HM5rMrvd78R4IFFDdPpWfZ eJozOCzJ3HXSRldixJNpLeAsl6gDIiygrhSIBuzWdn4givzEmaYMBv+i9 pqVpuAKIefyYkK2YMImalPdLArXHkTQDxGMpdjUYrzA6NO3S80Lr4z04n MIHnylYO0DGW4wedzC/cy5E2LuAhBDIUkJU2IBYJsFYTPZVTugF5mMIwZ Yjhryhdkk55Vp06xoOT3jfjc0QnXSMmti4eHhussw+1DVZOwAMRUEDSTj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="370989162" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="370989162" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 01:55:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="790889249" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="790889249" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 24 Jul 2023 01:55:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qNrM9-005Npy-1t; Mon, 24 Jul 2023 11:55:53 +0300 Date: Mon, 24 Jul 2023 11:55:53 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 3/3] serial: core: Fix serial core controller port name to show controller id Message-ID: References: <20230724050709.17544-1-tony@atomide.com> <20230724050709.17544-4-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724050709.17544-4-tony@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 08:07:05AM +0300, Tony Lindgren wrote: > We are missing the serial core controller id for the serial core port > name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to > avoid issues addressing serial ports later on. ... > - return dev_set_name(dev, "%s.%s.%d", type->name, dev_name(port->dev), id); > -} > + if (type == &serial_ctrl_type) ... > +} While at it, have you tried to use --patience when forming patches? Does it make any (better) difference? -- With Best Regards, Andy Shevchenko