Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <tencent_7098E5576B2FD785B3A3B9CD6CE0643D4C07@qq.com> <4d862263222c7358840745c2cd0ce0fa@208suo.com>
In-Reply-To: <4d862263222c7358840745c2cd0ce0fa@208suo.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 24 Jul 2023 10:55:18 +0200
Message-ID: <CAMuHMdVOXvNykCmzJij=ZrVCxnM0DSrwB4_mX6c8-d7ztzNSUA@mail.gmail.com>
Subject: Re: [PATCH] m68k: q40: prefer 'unsigned int' to bare use of 'unsigned'
To:     xuanzhenggang001@208suo.com
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Zhenggang,

On Sat, Jul 8, 2023 at 6:06 PM <xuanzhenggang001@208suo.com> wrote:
> Fix the following warnings reported by checkpatch:
>
> ./arch/m68k/q40/q40ints.c:172: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> ./arch/m68k/q40/q40ints.c:211: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>

Thanks for your patch!

But obviously you forgot to run scripts/checkpatch.pl on your own patch:

    WARNING: From:/Signed-off-by: email name mismatch: 'From:
xuanzhenggang001@208suo.com' != 'Signed-off-by: Zhenggang Xuan
<xuanzhenggang001@208suo.com>'

> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -169,7 +169,7 @@ void q40_sched_init (void)
>    *
>   */
>
> -struct IRQ_TABLE{ unsigned mask; int irq ;};
> +struct IRQ_TABLE { unsigned int mask ; int irq ; };
>   #if 0
>   static struct IRQ_TABLE iirqs[]={
>     {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
> @@ -208,7 +208,7 @@ static int aliased_irq;        /* how many times
> inside handler ?*/
>   /* got interrupt, dispatch to ISA or keyboard/timer IRQs */
>   static void q40_irq_handler(unsigned int irq, struct pt_regs *fp)
>   {
> -    unsigned mir, mer;
> +    unsigned int mir, mer;

This part is white-space damaged, and thus fails to apply.

>       int i;
>
>   //repeat:

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds