Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2870817rwo; Mon, 24 Jul 2023 02:35:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlEb4Rg9i2VFdJ1GcAN0Kl1OnDWsWeMK0x2mh6cs/bFirMv0vV3d+nFIBxukwDJULbKL7na6 X-Received: by 2002:a17:902:ea0a:b0:1b9:c61c:4c01 with SMTP id s10-20020a170902ea0a00b001b9c61c4c01mr13494886plg.9.1690191305787; Mon, 24 Jul 2023 02:35:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690191305; cv=none; d=google.com; s=arc-20160816; b=fwfqHhFfbDtcSEPBpvkI8DpR/tPCoiXtTISDiKW5m3VjxEqr8zBnFGCXOaxYHGKIZb M6NGidXVJjh3r4UuweRsaLUawDlFBHrqQK4pc4tF1LahhhAYuBQXAGuB0Mg6lLbAuN/a lj4JQXDq0tSg6C+4rXFEsWf2SXeEQDywEFhc/CQC34ALqpqa6qAzcVgsbb3YVYMpx8sW HS9mEQUxqfB4YFbi9Fk/PaAyyFuF1X9C4YL5J4sAZht7TxlG1ZHigq1mfjCXugYPIgs5 Lx+KePkXw3qwAiS/2/Xxs8dUJGY8U2guDvLpZ6SIrHaZ14EIyotGESJIa6dO50AtbpWX If4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ggp5NVO3G450+xHAuKEvw9+AnVafbHQ4IlSn64AITmY=; fh=Q8R+ocd/vgHKVj+9bIsTNH/I3rxIMnxaWZN6p4yi3U8=; b=WSipCbjbwkw2C6fLTkhnfg4TjruRfQWa2yRvQjUc5AuFZ9m1tyD3QDw0ubuVYKTTLu 0oOzqBhapYaHDxXdlscw60aJ3+5ayVCpHndqsEUu5ygoRnAiEfenYdJEwpVtFoRwryDN IMzjGo8LXq7+5mmgzbwn/pp1Co663Fm+NTwzn5ejTys3gLA9VzYlviWsY52OzXhhnCYT yjUmV+LTg06CShqXClyb3ZJPLp/NP2cwerapLN86PK+srdZKYT6JHbsua4t4aQamEuCO 5ZT6zGSH8z/pXHbtCrbowWSL3rx8scJT7ouKfJadeMxHTDLG2yZSH4H6AohpAbqBEtiL Usxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E9ltUVdf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u195-20020a6379cc000000b0055381e05244si8302167pgc.777.2023.07.24.02.34.53; Mon, 24 Jul 2023 02:35:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E9ltUVdf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbjGXIwt (ORCPT + 99 others); Mon, 24 Jul 2023 04:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231917AbjGXIwq (ORCPT ); Mon, 24 Jul 2023 04:52:46 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24FFFB; Mon, 24 Jul 2023 01:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690188764; x=1721724764; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AFK87Oy7ijOEjIfPgqTKmw5kmr9MTaaez0cnQ9KaiPk=; b=E9ltUVdfCeVw77AuoXWmkZPDA7VYUlSofBtZ/nnkLD/3RBKgmGsBKQXU IGlPOv7uSVmyf+7dbFkbnakI+WKRem6yyyULybPsoBenn+j1NkbyKwoVc 7naGuNj2jSzO1BiWAMFNCrKyorbyU4/KsD8Qme+FIwUgiCBBgh6MD+m2K ySK9zQE5Z7m6Hmqt+5nkUTgzXxoT9FSSXjGRbRwGIRtY5X5e5o/y0mnNm GCaEJu3YsDj7Yjrg8GjBXyEbVxgGsJwbrW5FAhH/7kWtJsUgaZXrgwmlN Cv7B+ukThpsUokg3dHm4j0aPKU4GC0SlSffJDv7FWl+dkZHIYdRyODlms w==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="398288419" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="398288419" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 01:52:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="728833974" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="728833974" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 24 Jul 2023 01:52:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qNrJ1-005GiM-2f; Mon, 24 Jul 2023 11:52:39 +0300 Date: Mon, 24 Jul 2023 11:52:39 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 1/3] serial: core: Controller id cannot be negative Message-ID: References: <20230724050709.17544-1-tony@atomide.com> <20230724050709.17544-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724050709.17544-2-tony@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 08:07:03AM +0300, Tony Lindgren wrote: > The controller id cannot be negative. Let's fix the ctrl_id in preparation > for adding port_id to fix the device name. > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > Reported-by: Andy Shevchenko > Andy Shevchenko ??? Missing Reviewed-by: I suppose? -- With Best Regards, Andy Shevchenko