Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230713080020.72931-1-panzhiai@cdjrlc.com> <9dc7423a9e54f849212f21a59074ffb4@208suo.com>
In-Reply-To: <9dc7423a9e54f849212f21a59074ffb4@208suo.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 24 Jul 2023 11:00:37 +0200
Message-ID: <CAMuHMdViE_OMQC=Y9T30oK6Ho1zXegLoYN4KhWGHzuimkpeGTA@mail.gmail.com>
Subject: Re: [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"
To:     hexingwei001@208suo.com
Cc:     sammy@sammy.net, linux-m68k@lists.linux-m68k.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Jul 13, 2023 at 10:09 AM <hexingwei001@208suo.com> wrote:
> Fix one occurrences of the checkpatch.pl error:
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Xingwei He <hexingwei001@208suo.com>

Thanks for your patch!
But obviously you forgot to run scripts/checkpatch.pl on your own patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From:
hexingwei001@208suo.com' != 'Signed-off-by: Xingwei He
<hexingwei001@208suo.com>'

> --- a/arch/m68k/sun3/idprom.c
> +++ b/arch/m68k/sun3/idprom.c
> @@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
> machtype)
>       prom_halt();
>   }
>
> -void sun3_get_model(unsigned char* model)
> +void sun3_get_model(unsigned char *model)
>   {
>       register int i;

Whitespace-damaged, so it fails to apply.

These problems are present in all your patches, so something is\
wrong in your workflow.  Please test your patches by running
scripts/checkpatch.pl, emailing them to yourself, and trying to
apply them.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds