Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2881508rwo; Mon, 24 Jul 2023 02:49:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlF3NvPNXCB1ydSSONRjwkOJY4twuNZMsBss3zE7T+XyLk26ePQ+cO75U+aXC3G1jm/I3OWN X-Received: by 2002:aa7:d34d:0:b0:522:2aba:bb32 with SMTP id m13-20020aa7d34d000000b005222ababb32mr2136859edr.13.1690192193466; Mon, 24 Jul 2023 02:49:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690192193; cv=none; d=google.com; s=arc-20160816; b=oazcBYWYAq4ptO8jEaTmE95SDmbzqkUfDKqChYxAgxupeUTv1Lf+jmBYxnNPgLi6st Wxa9FM4hHNgvAPUMLBXu9rHpM0SVaXCo2DpldxdVz/CVOkMxbLUuhxsfQ8K2j7X23NN8 NNMhc2HHryiozsgbrrRt+gycXtaIMiVwt/phdCbK+Lpxqcvvh27jWb+zN6VotDjQeaU3 xGRrfuGfsBXQJhRdf3f38n/d0vkZzGXyRXKGpvuIywWfdV+0NvOPfWdCL4iP0DAGehjq IyN375kJoD/sKt0ABEGk9Ijcy7WBwI+vMe0lk5buyALjh5RQVt3rdYNhPnFlK+D/iFPL g44w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=lcc0VwYrlT1E7PEgvFDL6PneMWy9XGB7K8wngN/IhDY=; fh=uaLhahuCMsL2N2QJH3CxPhFN0Wj3vlAHdxXT3GTzEW8=; b=XfKHr28KxcsI62OHfhxq1pP/hb+Hw2hduCoyQLSZ0dyZcePmyJtwbEuKa6fNAQo7WG hkS//Qx7rFnyxSTodIdqwMnKBQ/pX5sNdmTA3QrUVYwRmx548wAqRsFemxdMAr8ld9/k bvbL+kt75CPJ51stNneJO/esiIwUMGQMpfKKPACL0O2kyy8STUf2gAADg8vVouOcqEZ0 0MtvK9IXJJ9I0dp7K9/uyiGeC/C/9Sp3GoQnMmsWs7p4X7YzdIU2aFIce82YBvW0n9FZ OJaAWx1Kbr1SpJ7v3YrjC9QFT/njmdCgaZyhKDv2U5oZn4PHPC7HhGegARCLFy/kmNa8 h5qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B9Gh+y7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a056402344100b0052228f1f784si1962871edc.148.2023.07.24.02.49.28; Mon, 24 Jul 2023 02:49:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B9Gh+y7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbjGXJpV (ORCPT + 99 others); Mon, 24 Jul 2023 05:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjGXJpT (ORCPT ); Mon, 24 Jul 2023 05:45:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E799CE41 for ; Mon, 24 Jul 2023 02:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690191872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lcc0VwYrlT1E7PEgvFDL6PneMWy9XGB7K8wngN/IhDY=; b=B9Gh+y7Jl6Bpn0SN9KrQMzrX7EEhrnks22QK3nEpNonfg5vGZVV+fiLPClvxtb5NvO76/w 5Kf0uYE8JYdO3iOIu7b1Gp/RSXscmeIN0ZeJGV8yT8G/M2VWSNaOduxdSfcvaMOSqiBQUO jlu6NWwyimuYzjyw72mW8ZRQ08pa6xs= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-zUuadyWlPVCQ0U_JCQHkbQ-1; Mon, 24 Jul 2023 05:44:27 -0400 X-MC-Unique: zUuadyWlPVCQ0U_JCQHkbQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E1493806703; Mon, 24 Jul 2023 09:44:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 734FE1121315; Mon, 24 Jul 2023 09:44:25 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230629155433.4170837-1-dhowells@redhat.com> <20230629155433.4170837-2-dhowells@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Matthew Wilcox , Miklos Szeredi , Matt Whitlock , netdev@vger.kernel.org, Dave Chinner , Jens Axboe , linux-fsdevel@kvack.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <63040.1690191864.1@warthog.procyon.org.uk> Date: Mon, 24 Jul 2023 10:44:24 +0100 Message-ID: <63041.1690191864@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > So what's the API that provides the semantics of _copying_? > > It's called "read()" and "write()". What about copy_file_range()? That seems to fall back to splicing if not directly implemented by the filesystem. It looks like the manpage for that needs updating too - or should that actually copy? David