Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 11:39:53 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Rob Herring <robh@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, peppe.cavallaro@st.com,
        alexandre.torgue@foss.st.com, joabreu@synopsys.com,
        mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add
 phy-supply support
Message-ID: <20230724093953.h7vs6gzrpk3ieznv@pengutronix.de>
References: <20230721110345.3925719-1-m.felsch@pengutronix.de>
 <20230721142433.GA1012219-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721142433.GA1012219-robh@kernel.org>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hi Rob,

On 23-07-21, Rob Herring wrote:
> On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> > Document the common phy-supply property to be able to specify a phy
> > regulator.
> 
> What common property? I don't see any such property in 
> ethernet-controller.yaml.

Not in ethernet-controller.yaml but there are at least a few user of
this binding:
 - allwinner,sun4i-a10-mdio.yaml
 - allwinner,sun7i-a20-gmac.yaml
 - allwinner,sun8i-a83t-emac.yaml
 - fsl,fec.yaml
 - rockchip-dwmac.yaml
 - rockchip,emac.yaml

Also there is no <vendor>,phy-supply nor <ip-vendor>,phy-supply,
therefore I thought this is common.

> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Changelog:
> > v4:
> > - no changes
> > v3:
> > - no changes
> > v2
> > - add ack-by
> > 
> >  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc23..847ecb82b37ee 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -160,6 +160,9 @@ properties:
> >        can be passive (no SW requirement), and requires that the MAC operate
> >        in a different mode than the PHY in order to function.
> >  
> > +  phy-supply:
> > +    description: PHY regulator
> 
> Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, 
> this property belongs in the PHY's node because it is the PHY that has 
> supply connection. I'm guessing you put this here for the latter case 
> because ethernet PHYs on MDIO are "discoverable" except for the small 
> problem that powering them on is not discoverable. 

All kind of ethernet phys connected to you etherent MAC which need to be
power controlled by software. You're right this sould belong to the PHY
node (as Krzysztof already mentioned) but this isn't the case yet. As
you can see there are at least 6 user of the exact same binding.

Regards,
  Marco