Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Viresh Kumar <vireshk@kernel.org>,
        Damien Le Moal <dlemoal@kernel.org>,
        linux-ide@vger.kernel.org (open list:LIBATA PATA DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v4] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
Date:   Mon, 24 Jul 2023 17:57:10 +0800
Message-Id: <20230724095712.1541-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q+1Q9lI6JcKBDUBj/za7UsGvACn+et7+Os0SGM3NO9MlSm4kK3pQHMXe1BJI?=
 =?us-ascii?Q?ygcrI16Dm5j51b8zXFVe32/BHNeicfhgfpZS5FqfQcHIHTLG1sQlWO+cBSu0?=
 =?us-ascii?Q?GAU7gxmdEs3WFixN6Sh9GFwHYTHJOQS0Emq8JA1uk2Dg3cGKTS4v0hsdLSil?=
 =?us-ascii?Q?oySXOsRArkr1On/aN5YdghEKoVdElGBmwA401bKZ7kPYdEfYeJZtfIjbrfLK?=
 =?us-ascii?Q?v9D5gzgLIrlaG/3WzQWqBv8i4XR57tse2BE0c6H6TGrrqT2DzeOoq9xx5XWt?=
 =?us-ascii?Q?opSrnGnBFS/i1Rbnh5T5fpv2ru//cFmbkbwQ09MILh3V/5fENOM0/ZgqGk9r?=
 =?us-ascii?Q?oYzgynwpX5PUvqBAUm/1hh5EVD1s6LOeoLFYyjZ1HO/+Y3plNXvWnXEQHMtI?=
 =?us-ascii?Q?pP1sgMBBlWbcbKItXRxDulN66WmfHrkMM8vWrwNEKMBmNmGkDCPq7LsgX/PL?=
 =?us-ascii?Q?10Su3qQfJuX8m3cHuGHuJkGwuIIKWJlNuSjAmxhvdE2OIdRoK0zR4lYYcN12?=
 =?us-ascii?Q?FqdQzsONSJ4HOL7t+qiVPYnjXovafHI7WNI9HzZ7dZ1HfRKYCpkdYy7B0G3e?=
 =?us-ascii?Q?npRHKRD9CUZsS85PtCJW4NVvbMwDPKqIkioB02OcjgQGlvb/p5qk88AgWwbG?=
 =?us-ascii?Q?ybunMQuEeeE+1fAhstGtPcwNlxbWWUy837IqLiITIjvQGHNdO4hZIK2Rxch4?=
 =?us-ascii?Q?Hda2s1+HCiJ7LGhOj5/lyRenFUbPBuXOKEwc/5sqE5YsSXhb4l5ByxCICLyd?=
 =?us-ascii?Q?rWtX9AyEv2/7/qpTRImk2zNP1csxShoX235Sn3EJDu923vdVMrJfhRK3rvM0?=
 =?us-ascii?Q?UTxxgsUrBVu4ZFgbYbmAV+irfgd1VMhVq1JpX9gK6JzIFxdrOsbGijLNwMDn?=
 =?us-ascii?Q?5JSiWGGKHsZR64uonKc+yNOxvZ5DSa5PRtOUlr8emcPA95v+tqdWlzHCXGNF?=
 =?us-ascii?Q?79cDSmxk3SQVuxkU74OrmlrFEMKmdw0UlUwsr/AiEwNidZfT5pGfI91czIUn?=
 =?us-ascii?Q?APp+TEMvZFb/sc+MdXedleevsiXk+KCsV9dJBTMQ3IIca/ZPptDUWitvSnnx?=
 =?us-ascii?Q?2/Gh7kSfrssj2LNUwLgRRClQYUKfvj4WOgNKtCQSocq7i1RiVGIQY48QJI6/?=
 =?us-ascii?Q?cf7kuRajYpajieCbFn+LDFcrmbX/sonL6LH3ocUAXhdWteC3y2cCSDLOz7lw?=
 =?us-ascii?Q?uHXpt2m+5X3NGbzQecOicx6kdLYTthPGYyO/2934B3M/0OyNOxtiTq7q84ZN?=
 =?us-ascii?Q?jPp3rf/0qn1et1FovkQYELZdOLk/VO6Re2b0Ryj5MTtxfaOpEB3ioNUtUP6M?=
 =?us-ascii?Q?zcDO0X0IDiT112qSpaWWeKb1t251PQB4KHV5dDZ/nQeS00/o6B0w0hQiU++S?=
 =?us-ascii?Q?mHEfCcLYBB9aW6QvZRh6JVyL9fQSvWUFw0pHtlswFjBY5P59eGRXr/gS08V9?=
 =?us-ascii?Q?KHCHCnDGOJGMJ5vtuNDhkGnvWsNZRSsbQXgG0WoElm0kZ2gpzvPfv9DaodzP?=
 =?us-ascii?Q?Wxmr13NGC+iMdXJh95ORIDQiojbFYAzTVnAvtlRqTLOv7EJ5CWiKRVpxWOLA?=
 =?us-ascii?Q?zO1g0ruwtqf9jzgac4uBJGsPsTYRqf85cdq3y1h9?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be916be-0518-4546-181c-08db8c2c6f45
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 09:57:47.9838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: INfSwjW6coM9M2WcEu3b8ZOLAmxniwU+DsuDlJYyQzvEytrNtMIwMEKgS/Cb5nBBIEkja6O5GhlAbdZRwdgelA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4448
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible for dma_request_chan() to return EPROBE_DEFER, which means
acdev->host->dev is not ready yet.
At this point dev_err() will have no output.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
V1 - V4:
Fix code format.
---
 drivers/ata/pata_arasan_cf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 6ab294322e79..b32d47112c0a 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
 	/* dma_request_channel may sleep, so calling from process context */
 	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
 	if (IS_ERR(acdev->dma_chan)) {
-		dev_err(acdev->host->dev, "Unable to get dma_chan\n");
+		dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
+					  "Unable to get dma_chan\n");
 		acdev->dma_chan = NULL;
 		goto chan_request_fail;
 	}
-- 
2.39.0