Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   carlos.song@nxp.com
To:     andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com
Cc:     carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] i2c: imx-lpi2c: directly return ISR when detect a NACK
Date:   Mon, 24 Jul 2023 18:55:44 +0800
Message-Id: <20230724105546.1964059-1-carlos.song@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BJSeWJNc1SekrAVCPr7jVMKgsWeVNbQh+3XsGa9dwM+3BUir8+flYCu78ndx?=
 =?us-ascii?Q?oewM0qQrtlBERX99lVgnuNf5vuQW3WRtnBfQQ8C+Q83appOy5ZpbtvG5a24f?=
 =?us-ascii?Q?DqpQ/GIQTz9PydFRHJ9dde3sP45JUycu7W7AG5jqzP4tDBIM9xfk7QJnjbvQ?=
 =?us-ascii?Q?8+AVSzd07ZzBainCpi67hpwoH8D458bXWOp4FhdJWAT/Uy9278Yw4EHnWcXf?=
 =?us-ascii?Q?+ZJUafh7SIeQ2y3gGzZKKhKfmuJq9oF7kVNqvukyLRD72C/oHVBVmz9OJIVI?=
 =?us-ascii?Q?mL0K3Bp4NlESEZb5SwdqM8KZKHJOdKRChTiNTAXvhxPN+fX+p48ZyC64uO3B?=
 =?us-ascii?Q?1tTM+f8lqyb0uzV9sCGR4uuQh7aWKThCHh39uk5Y3UkjYpOYal6hAUj4NP+Z?=
 =?us-ascii?Q?0Vdf1hKZ+Q8yV4AG9lvoICjqmQFqaPg48bwZpg9nW+E/d/dAM4FvI8CuViVa?=
 =?us-ascii?Q?2m21g7fwbJGI4jWmMFvG/PFnG/1xTkwACC3Kn5YGTTA2d8SiXsnSCCB+M+mY?=
 =?us-ascii?Q?hCtkfa27uH5G4G8bNH25wsWgR8mniwcohcBGm61VsJ4XB3A0Ge8VKR0NsZgp?=
 =?us-ascii?Q?ikGrVSmm4DlfEqnVA6bRKICT2Y/9CNSrp5zQPIUXdiiipHwNNuwex7D2f+yp?=
 =?us-ascii?Q?Att9fHg4UoxyJVEg1b85kxiGjm+lljQqAXH7ZXe2zqg1gcOztG7tel9UR+HP?=
 =?us-ascii?Q?yxxKLI+u6qWJf6bkdSI6XPujynuDZiJh/fsatMx52SIokSrpYe0idI+z44Zs?=
 =?us-ascii?Q?fYylDl9+9vMZzElLrq7Ktc9Rk6T5Myvaqruki+2b3iFF7l6hwvCVopZ+Kej0?=
 =?us-ascii?Q?pw1FaFQ8pDFfV4Lrj2sBUXIO8MoNMmVGauUkXdxctRgyzYfi8zRZc4PxgwqL?=
 =?us-ascii?Q?xIFsvdeD56YZ1Pq36ZwRGmZyCteR/5mrqm/eD9AZm0j6a6kWb3AIKojcie1L?=
 =?us-ascii?Q?1/YBiAXNWREIK0eUXO9mrmNyX8t2FAGT/AQ59NJQ16xObwC/0bUxKZFGXyDv?=
 =?us-ascii?Q?55FL7za3/pym/s4d+94tN7o4/u/3c8W/xcjyEU9V91iYHwsGNJG2g4wIVIKF?=
 =?us-ascii?Q?3u12XHUkkvsBVLHmpyfgbBImTUDs05HstDaXVAgnTiX2yZAB4SqxO8UeQ3EM?=
 =?us-ascii?Q?wv154OO93NkrB5OZahyIDisqlFeWXekJII3tll7aDlr7z5EPwi5oUB8BD/WR?=
 =?us-ascii?Q?ZQOFiYC9qqBoesoiNrQr4LqJJGpwXT4z6tsS71Qn6Yp08es5kw9UdSZhUY/R?=
 =?us-ascii?Q?QnWLUyKTaBYEB99QCm1erdDnHhimAeSCF5BXUkrzdreexveQGJrAv8O6JTqM?=
 =?us-ascii?Q?hsSvaHAbvqraUUCikOJj1lx6KcJHoMUnmp+QsR4W7LK/hML9/JaRxbeFa6TS?=
 =?us-ascii?Q?Cu1UNEaRkNdPuvDu90bD7QX5WBwslY9dcKikeffyeSjISS3OfeY42iVaEPsg?=
 =?us-ascii?Q?mb8xsETMxPONNiNw3hBft9OJY6ZAiOMSY+svZZrQL0Es9jZ3QnNNsHxySZlz?=
 =?us-ascii?Q?2MlheT11VYsZUdTg+1uOcGeJE8w25x7CoEa+Oq2Dzv7RtWl3f/lAyeEQAgtw?=
 =?us-ascii?Q?TNCosh+UAf1a2pdMsJYMQ6WJ6b0alUqq3zN3KTnO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5185faa0-f32c-4894-2a95-08db8c34057a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 10:52:06.4582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSIry2RRLxWv1Jvyq54WQzYtkNSgV4jVuIMB0ArdV9G+VpSCQ890efRaC2SxGggK2hcv1OEdPrYydsWxGwtfcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7288
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gao Pan <pandy.gao@nxp.com>

A NACK flag in ISR means i2c bus error. In such codition,
there is no need to do read/write operation. It's better
to return ISR directly and then stop i2c transfer.

Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..158de0b7f030 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -514,15 +514,14 @@ static irqreturn_t lpi2c_imx_isr(int irq, void *dev_id)
 	temp = readl(lpi2c_imx->base + LPI2C_MSR);
 	temp &= enabled;
 
-	if (temp & MSR_RDF)
+	if (temp & MSR_NDF) {
+		complete(&lpi2c_imx->complete);
+		return IRQ_HANDLED;
+	} else if (temp & MSR_RDF)
 		lpi2c_imx_read_rxfifo(lpi2c_imx);
-
-	if (temp & MSR_TDF)
+	else if (temp & MSR_TDF)
 		lpi2c_imx_write_txfifo(lpi2c_imx);
 
-	if (temp & MSR_NDF)
-		complete(&lpi2c_imx->complete);
-
 	return IRQ_HANDLED;
 }
 
-- 
2.34.1