Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ce978c1-825f-c1fd-41e3-eba2324cfd56@intel.com>
Date:   Mon, 24 Jul 2023 12:30:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] scripts/link-vmlinux.sh: Add alias to duplicate
 symbols for kallsyms
Content-Language: en-US
To:     Alessandro Carminati <alessandro.carminati@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Nick Alcock <nick.alcock@oracle.com>
CC:     Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        "Nicolas Schier" <nicolas@fjasle.eu>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "Daniel Bristot de Oliveira" <bristot@kernel.org>,
        Viktor Malik <vmalik@redhat.com>,
        Kris Van Hees <kris.van.hees@oracle.com>,
        Luis Chamberlain <mcgrof@kernel.org>, <eugene.loh@oracle.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
        <live-patching@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>
References: <20230718125523.2fc05491@gandalf.local.home>
 <20230721092127.1931028-1-alessandro.carminati@gmail.com>
 <CAPp5cGRBW6WDm9ku3nsr0x=rhEOGAUx==BctCo+DJ+498Tz2Sw@mail.gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <CAPp5cGRBW6WDm9ku3nsr0x=rhEOGAUx==BctCo+DJ+498Tz2Sw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1NYUHI1cnAzR25zSjBGQ0ZIbnBaMElhWFdxN3RuQjJGVzQxWk4zSVkrTzBr?=
 =?utf-8?B?ZFhQdElLS2szckpNUWF6SmZ4MG1XNEI3M1FnNXBVZC93YlFlRnVnNDB3Q2NM?=
 =?utf-8?B?VHJRQm1qMkdhUnRkbUFXQ2lpSUc1Ym1QamZLS0lEZElWVGwwNVBhZXYyYUlB?=
 =?utf-8?B?SFd1TjNrS01uSVFqQjU1OFcwdUE3S1dBa2NZTzNRUVJkWitHTzU3Ri8vaTNB?=
 =?utf-8?B?a2x2WVdVZVk4WnNUNWFPb3liRkNSQ1dMT3puUkV4Y3MyWGlyU0g4Z043VE94?=
 =?utf-8?B?V0xKSEE2QmE2VDVPOURCWDVoV0lwS2NrVUs0ZFdFQWEzSkViQ2lPb2JXSmp2?=
 =?utf-8?B?aWNWNmI1NFdaYUpaVHV0MDFhWk5uWEtmenhSTVlFOWQzUVVHYXAwZTVZS1Fr?=
 =?utf-8?B?c3RZSysxdUhvVG1LQWpFMmJENU1TaytUV2xaeFdSbjAxYWpTa3dEc1cwR0Np?=
 =?utf-8?B?dDdUbGFHMC83NjFJY0hoVHZNVXBKbGF6ZTBDeFFhY0VqRlloSUI4b0VieXVL?=
 =?utf-8?B?V3AxUmhqVnlSTDBKTUdFUzhad0NZcXlrb0R6bUtCZit4MmJhVWJEeW1QYjRU?=
 =?utf-8?B?TVZVbGNQbUZIR3dBZmpnWUc1TW1XRVd3cGZZNlVGWE1hcnpoTnpaZzlXN1Rx?=
 =?utf-8?B?aG5ndldlTm5qQmpQZWQ5em9KVEFDZlhxZmhyanFkbExwVXl0dHFhN08wbjll?=
 =?utf-8?B?WjhORDRTbmVicDBOTFk5RDhITkxzS3lldm4rVmliUUU2L0FIUStMNVJzRU0v?=
 =?utf-8?B?Z016MStXZitIREQ3aGlSeU1oTG1JeWIvTkI0RXROeExEbVRVWmxybTJwZUtz?=
 =?utf-8?B?Ylg3anZXeFY1bndjWUhCZjFBcEN2ckhzY3ZJWm1PbnRwdzlKcE1ibW5ySnM5?=
 =?utf-8?B?ZFQyVHF4SEQ5MkMwTysyZG1Udmc3WS9Ba1A3disrVk43TGV0WVhaYVZtU1ZO?=
 =?utf-8?B?ZEs1Wmg1eFRnZ0ZJdC9oM25qQWh0ZDdCalUraExFZkRsdzdYYnNRbndHRUtk?=
 =?utf-8?B?TW5OSk1VVnNOem5SaU5ORDNSaU1welJFRHRmTC9vbEpHZU9aMjFYZ0NQTzlV?=
 =?utf-8?B?VENURjEybjZBM0NRRVFLUWFzZElPb1FHUDhjaGNQbUtvaitIdjdGSnVaMEg0?=
 =?utf-8?B?NzRBYWMzUjBodkcxL3BMRkVmUFg1NFNxYlYrSUJWZWlYcEJsdTdjYTRpdkZG?=
 =?utf-8?B?alhsVXE0Z0JONGg2L3doYzB6RlF3L2d5VDhMT3RSejFqVWJydE0rWnlGRTd1?=
 =?utf-8?B?bEttSTNaTm9KR2NIRGVKU0QrdWwrNEZpd25JMnRIcGhhVWNnNkpJUjU3cjhC?=
 =?utf-8?B?aStzNTFlTFlwRVpvdWRuVHA4RnhMUXh4QzhFUWtTWmI5RDYzY0ZFVWpSd2FC?=
 =?utf-8?B?NmZqbUdPUHVBWFMwTFlqeDJCYk05WUUxaWJpanB0Yk1WKzVHT2RFcDdIY1FG?=
 =?utf-8?B?Y0lEQ0Q0eGQ3MkptQ2NvUmJuVm5sSEFkSVVwZXd1SWFDVGRDelV4Z0lnUlZs?=
 =?utf-8?B?MEpSeFRZdjJtaUNSRDdHMmlCeENQcVVheXNxNmtuU0xtZXBtZE9NbS9wR0Nm?=
 =?utf-8?B?eUJaU2R4THk3MjE1MkxTKzNBTHNSdGhOTFovRjZsTm5oQ1RTUW9qbk5ha3N5?=
 =?utf-8?B?dWFlN3QxWDlqT3lLV1ZBWkhzeGJqLzgwWjZaUG9SWDRtNk5oVEsrRFZ4K2FR?=
 =?utf-8?B?ZW03Rlc4V0NxemxpZ1BpYjRIVDljZ0ZkaUYzdFZvQWVPUVV5TFU5WFFTd2hT?=
 =?utf-8?B?NnJuK1VXd3BiN0NnQUFuclA5bEh0STI1VFhOTUJucmQ2bWxPTzVtbURJSEJ5?=
 =?utf-8?B?U3FEV3NhUlJCanA2MzhMSGxSd0JONlBYSmRzbnAzRDhWV0Z2dk94eDBiTUc1?=
 =?utf-8?B?TTBzb1ZaTG9UNHBiT1hBaUxrTVpIeHZtQUtVSDgreWdyZ3hYOEdaRGF3V2Fl?=
 =?utf-8?B?L1ZOQWhGRERtSmEzbGdzWFQ1UC9veDArd0JqdllrcUswc3ZJdmRBLzhsNzVT?=
 =?utf-8?B?ZzJnVklQTHhScjlIam5rZnNZenFNQ0lVY3hEQ2ZtTVY1MHNFZWM4cW93YmZH?=
 =?utf-8?B?RFNWWGFGdjBEMG03cGN6ZlQzUHhydkNqK0ZPaGpYSGFMSW1RaTdTeW9JQkdL?=
 =?utf-8?B?ai9Jelg2cS9yekNGb1lnelV3a3dTSWcxaktxMHFYbEJaSDU0ZUQvYVRMak9w?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae45dcff-5f3f-4217-a3f0-08db8c314103
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 10:32:17.7463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zTxfY+5TP21iBL7F3Uz5jtgI0Iej6H0ZkDfUxq2m4szVepT3g+NuZe27Q6dtZj+CtezFZtyi21DXHqoZRYVKy3+kraatnriy9DORbnVb95M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5928
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alessandro Carminati <alessandro.carminati@gmail.com>
Date: Fri, 21 Jul 2023 14:40:54 +0200

> Hello,
> 
> I apologize for being noisy today.
> 
> In an effort to be collaborative, I would like to share my thoughts on why I
> see duplicate symbols in fs/binfmt_elf.c.

[...]

> ~ $ nm -n built-in.a | grep set_brk -B100| egrep "set_brk|\.o:$"
> fs/binfmt_elf.o:
> 00000000000000d4 t set_brk
> fs/compat_binfmt_elf.o:
> 00000000000000d4 t set_brk
> ```
> 
> These two symbols come from fs/binfmt_elf.o and fs/compat_binfmt_elf.o, and
> they are just two symbols that happen to share the same name, as is common
> in the kernel.
> 
> at the same time, addr2line reports symbols to be generated from the same file.
> 
> ```
> ~ $ llvm-addr2line-14 -fe vmlinux ffff8000082f1d2c ffff8000082f4454
> set_brk
> /home/alessandro/src/lka64/linux-6.4/fs/binfmt_elf.c:114
> set_brk
> /home/alessandro/src/lka64/linux-6.4/fs/binfmt_elf.c:114
> ~ $
> ~ $ addr2line -fe vmlinux ffff8000082f1d2c ffff8000082f4454
> set_brk
> /home/alessandro/src/lka64/linux-6.4/fs/binfmt_elf.c:114
> set_brk
> /home/alessandro/src/lka64/linux-6.4/fs/binfmt_elf.c:114
> ```
> looking at the source code:
> https://elixir.bootlin.com/linux/v6.4/source/fs/compat_binfmt_elf.c#L144
> the cause of this behavior, which is unexpected but correct.

Oh man, that's some deep investigation!
Let me go back to my old tree I was sending RFC from and check that
particular case there...

$ grep set_brk test_ksyms
ffffffff814b46c0 t fs/binfmt_elf.c:set_brk
ffffffff814b7040 t fs/compat_binfmt_elf.c:set_brk

Looks a bit better :D

> 
> The rationale is that using source file + line number iproduces better kallsyms
> table, but it is still do not produce unique names.
> 
> BR
> Alessandro
>> As a final note, please understand that my patch was not intended to undermine
>> anyone's work. I simply encountered a problem that I wanted to help solve.
>> Attached to this message is my code, in case anyone wants to replicate it.
>> I would appreciate being kept in the loop, as I genuinely want to assist in
>> fixing this problem.

Thanks,
Olek