Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77b45165-e6bb-6ed1-f96c-90565740db2f@amd.com>
Date:   Mon, 24 Jul 2023 12:16:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 2/4] firmware: xilinx: Add version check for TRISTATE
 configuration
Content-Language: en-US
To:     Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Tanmay Shah <tanmay.shah@amd.com>,
        Ben Levinsky <ben.levinsky@amd.com>,
        Marek Vasut <marex@denx.de>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        saikrishna12468@gmail.com, git@amd.com
References: <20230724084554.1924378-1-sai.krishna.potthuri@amd.com>
 <20230724084554.1924378-3-sai.krishna.potthuri@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230724084554.1924378-3-sai.krishna.potthuri@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVVLZ25MN3N0bUd0RjF3NXQrcitJb2o0cHgycVB2SVFSZ3gyN3BqSTVweGlG?=
 =?utf-8?B?bk1seUZ4dFRMRU5KY0tZZG1OWlBDcjBaY1BBSXRqbE5DSG9UR3FWU2sxdWtI?=
 =?utf-8?B?RWVWVjRZMW1ESFpnaGl6ei9ELzJxYXNNWHhvT01Gb2lhdHY4RFIvUVMzdGdr?=
 =?utf-8?B?UHNwa0dxeGkyQWh2QXhqaEI4WURQTlYxcGg5VDVicG4xbUZyWndFejhraVBH?=
 =?utf-8?B?NWlEK0c1SnNzQk1vd1BZc1Fmd0Z1YXZLeDNld2Vwd2lJcVBLRnpPQjNXN1NE?=
 =?utf-8?B?N3orZ2RHbVdzYkJ4cEJNWjNRN0hDUVVNNk9ZQklTYWdnNWwxd053M09sTDdB?=
 =?utf-8?B?VFhyanJyTEJVeDBMWkVhSDVadVZyaUFuSDVGai9YUlorK01yOGl4R3Qzald3?=
 =?utf-8?B?SnpmajA0dmdsVzJyZ0U1WWY2V1VubEVBdEtNekg2NW1OL21WalZQcExjVE9m?=
 =?utf-8?B?MG9EbHFyQ3hqZzhUclNyejZWNjFERVVzVkFaWFdQbkx1TUNQUTZuMHdZTEJt?=
 =?utf-8?B?b2M1L0tNOEtQUDJqamxCdXZFUmZaR1Z2YTkxTS93RW53Vm4wK1lMOFYwdDJW?=
 =?utf-8?B?SWx0L21sc3ZJb3N2QmlQRThxMXpQK3hPM2pXUDlkaWkrS09tVU5rUCtGOHZI?=
 =?utf-8?B?Zk9XZGp5R2dkNVdkTGNTU2lwNllXY0FBL1NHNXpWck1VOXZSQVp5OFNRSW5q?=
 =?utf-8?B?VkY2UEovbjQ1RkVJM0FZQ0ZLbmhydWlaTDZmekJrYTA0MXBDQ3VUQ3dQdkJn?=
 =?utf-8?B?QUNwcXVVdDBqUG5nQU9QRldMRjdlOVZ4YWhBM0xrOU56WXpTSk5yUjJUcDM1?=
 =?utf-8?B?MkhiUU1DWFNNUnM1cU9rYVdRZEhiOHFlYUczeTk0Q2lLQnp2L3JFbkdMdHZj?=
 =?utf-8?B?V0R0T3R5bmdHRVVlMm9hZ0tOZ2ZOOXg2dHBEb1VhNUtNQjB5VkFuRnRoTHVT?=
 =?utf-8?B?cFBPYURwNmdsSFhTZXBIcWNwaFVZS1M1aUFBQUQ4RnlqNnFMaGtIWU5KRFly?=
 =?utf-8?B?ZWtpL1ZMZTFKOU4xblFCUkgvV204N2YzNE1pRjg1YnBaRUtYMDNIL2R2RkJ5?=
 =?utf-8?B?WnV4SG1SbFlXaGU0SWR2R1lPRzRINVdpZEZObXZ1MlZHQVFHNEg3UW4wVGJ1?=
 =?utf-8?B?NFZISjAxN2EvNFZhcTVQV3dpWm9OWDhHWVlVSXJVVlBWQ2lpZFhJd1lhT3c3?=
 =?utf-8?B?SmtSdFlDZ1dUT29ILzdVRHpUbWVsN2FWMW1JNGhoTHBlRFlBOVhvUWU3T0d4?=
 =?utf-8?B?NmJvTTkwc1k3RmtIVmdEUlh4bzR0b2VGek85bWNvbEF0Q0dvcnNNUlpoOTRP?=
 =?utf-8?B?Sk5LTURyQjJ6UWJZMW9LUzhwd0ZhWE5YRFRrUTRSUy93QzNmcnQ2QXA1dTlB?=
 =?utf-8?B?TWVqMmdUZW9iYngrbGd2Y1MwWW94NHRidmJpUzVTSHkxcWQ1TXMzUE5LbUkz?=
 =?utf-8?B?dlZod202c0dhdU9VdW1ZSDZrUmMzeUhaUFJ0ZHVwQmE2Skx3ZS9XemN3VHVI?=
 =?utf-8?B?NVYxZ1ZFR2xCc3FHTG8rMUN3Zmo3ZGY5MExKK0tPeUJSbGpvQmtlellaYjFU?=
 =?utf-8?B?MkMvK3NoQ2pRc2ZoVkI2VVNzMUlDYWJleTNXSEpXYS92dFZqeXo5RDdNY05i?=
 =?utf-8?B?dWIwSnQwVXpsOUNRdWNIQXowcCtqdldQMnlEYzlueTgwYmpzMFpBL252MFFj?=
 =?utf-8?B?bi80SENjMU1id3loSHdzVjdZZmlGWnBGUytra1RxOUFkbEdNMmFHcjBpcHFK?=
 =?utf-8?B?WXN0ZmI1bmxjOW1FMC9NV2RZWnVZdnFvaE5SZTdpaGxQeFpyL2d1MWUyQ1ln?=
 =?utf-8?B?a1pCSGlRaXVKN3VnazE2SlBDRURnNWpRRlY2Q3VoRGIwQkF2VDRoR241NnNm?=
 =?utf-8?B?TFV5RDBMZW5vcVZXelloV2wzbGNpUzFXeGdMd0ROcHJUeWhEbW9xaXZvbVd1?=
 =?utf-8?B?RlBmTVVwUmxNN2JTZ0hEVlhqN1Q1RjlqS3dZUXNGTXA0OG9FY2lRcGt6UWdV?=
 =?utf-8?B?K3JZWE1jQ3lVSUhCOTBRZFR1NEdKVGcrbXdyWnZ3TmV3eHI4YWlpZ0YxbE5k?=
 =?utf-8?B?N1h3ZTROckltR1dYOUhaNVdPK2dFUmowUXQxM1p3a2ZldzY4Q0xNNjZsVjJJ?=
 =?utf-8?Q?MCeziQRLFcT7cUYfM4IWmI85q?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46a79421-86ad-4479-d412-08db8c2f16fa
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 10:16:48.2851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IRV6tzUOjr4eDofnt0xCbw1R+GwspBZ2hrkjHTuaI+MtSqvucfcgOak2hNrB57Lg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4258
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/24/23 10:45, Sai Krishna Potthuri wrote:
> Support for configuring TRISTATE parameter is added in ZYNQMP PMUFW(Xilinx
> ZynqMP Platform Management Firmware) Configuration Param Set version 2.0.
> If the requested configuration is TRISTATE and platform is ZYNQMP then
> check the version before requesting Xilinx firmware to set the
> configuration.
> 
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> ---
>   drivers/firmware/xilinx/zynqmp.c     | 9 +++++++++
>   include/linux/firmware/xlnx-zynqmp.h | 2 ++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index f9498e7ea694..307717f24a98 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1150,6 +1150,15 @@ EXPORT_SYMBOL_GPL(zynqmp_pm_pinctrl_get_config);
>   int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param,
>   				 u32 value)
>   {
> +	int ret;
> +
> +	if (pm_family_code == ZYNQMP_FAMILY_CODE &&
> +	    param == PM_PINCTRL_CONFIG_TRI_STATE) {
> +		ret = zynqmp_pm_feature(PM_PINCTRL_CONFIG_PARAM_SET);
> +		if (ret < PM_PINCTRL_PARAM_SET_VERSION)
> +			return -EOPNOTSUPP;
> +	}
> +
>   	return zynqmp_pm_invoke_fn(PM_PINCTRL_CONFIG_PARAM_SET, pin,
>   				   param, value, 0, NULL);
>   }
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index d7f94b42ad4c..6359eeea8dd7 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -34,6 +34,8 @@
>   /* PM API versions */
>   #define PM_API_VERSION_2	2
>   
> +#define PM_PINCTRL_PARAM_SET_VERSION	2
> +
>   #define ZYNQMP_FAMILY_CODE 0x23
>   #define VERSAL_FAMILY_CODE 0x26
>   

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal