Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   carlos.song@nxp.com
To:     andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com
Cc:     carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
Date:   Mon, 24 Jul 2023 18:55:46 +0800
Message-Id: <20230724105546.1964059-3-carlos.song@nxp.com>
In-Reply-To: <20230724105546.1964059-1-carlos.song@nxp.com>
References: <20230724105546.1964059-1-carlos.song@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n2cKOuDipS8LF+MlJuDSt6JLMbpn5Tml37NGeVL9axtE8skKrqZ/Ar5R/5Ca?=
 =?us-ascii?Q?V9xopMsCCAJNdPQLET7MEkfG9bNdjhk2WomIw5vNScs72yQPUyO1SKFW86MI?=
 =?us-ascii?Q?b5p0J/Fnaip9wo6bUguL0lIF8ljBxgpnmzzq37q7ENHRNdnSZSPk4SvprIAi?=
 =?us-ascii?Q?XDkYYtBVxeZ9vk8+EyRjMiXNsoccKdrM24qsZ3USChk42Wqgw+ZvUVCfSMJE?=
 =?us-ascii?Q?bWTvCiQr+cYqKZydzW1t/8qREC7taPNCzeGi3zVx+Pf4SyFmPWSPRCk3nM0A?=
 =?us-ascii?Q?/iTiCSZjlUeke3FP2knLrODhF6Qt18BZxP1lk35BN00xNhLtBwtt2M56d/OC?=
 =?us-ascii?Q?o0oNU5Hatt7qKQ2QrJUywWBzXszvxv5KRO7W/JZVmilSXIoq2/NtfNtwVwZq?=
 =?us-ascii?Q?5DCpVvd8PUsRntL1T0SS7KXuSXyMarfxbLp1NJyX8bu7UzpCMnAy+3as4wKA?=
 =?us-ascii?Q?jWu6NYk+KB2UqhPIzppHEJnTp4Mpmq1HGGR4jlun7oVsa/uK387wUowFOadS?=
 =?us-ascii?Q?7BcIEu41t4Mvld7MGP7JooLTQd8GLFKVHv1zvRAcPLaTthNS7w4eKONoB7F3?=
 =?us-ascii?Q?8ZP1uPTQyt/Of0Mg4IKXLhVds1xs3fvfGwoxHoeN8YWSkStK/KmmhA5okZKl?=
 =?us-ascii?Q?mbUQHnfVCdDe9qPcKHuOEydX/ElXMI+i0uM+EnsQBoCGIEKC+GYCO3mE480f?=
 =?us-ascii?Q?RYlE0b5mIkvbGcM6RbfWrFzNaaVJwrCMw+6khcc5DuI3sE6P1uiUAIZKSxxe?=
 =?us-ascii?Q?D8VelOrzpZofL0xYTvQvh35Ft8Ti8E0XB17n0fk+4JmmZlbvyTSoyjmwZafd?=
 =?us-ascii?Q?ZKurqmbfT4/xH/VCik/pfRy6ziJPlRlWG5evXp8lanGhu9MSTfjZtVhEFDa5?=
 =?us-ascii?Q?qIdzCUUuonjY2r/8B8/B5lDb0JzwTxn6umbfLx8ZdbnI+1Ei7JCIsh+3Q/9L?=
 =?us-ascii?Q?sqB1nhiE+COLV2mAKZSQVLbI/UvgDpKE5AYw0GZK2/Dd7c1U/IRWabUbgefd?=
 =?us-ascii?Q?IoYDR3nZYfDGICz1BAYR701coUej9Gc98JUNzy9dksqW/mFkOGBimF/8jiSf?=
 =?us-ascii?Q?FSfBwP1HXiTroCptGZ1r37NogzCnNBJh6sJrNBfZ3rNfV2KXr/7DbZJEhnzo?=
 =?us-ascii?Q?F9CBVJuUUphjQILgzxOvOF65aWVauhLSrb3dN0fqAZnXdY5x5h7z41DLH11D?=
 =?us-ascii?Q?JqWTKflyB9s5UUo8vzSzEQDrZzPk/mRpt36TfUAOvbw7cvIEWFx02/KWc1m4?=
 =?us-ascii?Q?2cwBys3JUMI2f7eWVndtZckj4I+cXpajIwE4PIVFPHODhdf3lq5CsrI/Ts4G?=
 =?us-ascii?Q?NBlv+R6m6WEkBpN77rDbhiSD/F/DDrGgq2osd/OLxeQxoac8mINW+S4zsi5p?=
 =?us-ascii?Q?g/BakzI/0Ht85xt4g1lzB8BuGE4uiPMk5xgNP1ABGItam3xdxyQ3ptyWPHB1?=
 =?us-ascii?Q?oTk5fShylDZ2yzljJZcX8oLeWIF14llu2Vngoeo0lDSqK6J4jARfH4DQPpeq?=
 =?us-ascii?Q?mFUWdkjslbuwvJYQSRvcgNPBAKG21Xb5KOIKlHGbZNNminj0D7UWVG6vmvKf?=
 =?us-ascii?Q?vnqrwoGJSJMJaxCUzIF4fX4gKsMRqsmzI64HjYrs?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aac45896-638d-4a2a-2598-08db8c3411b9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 10:52:26.9813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vQ2AeugJc0pM6TKSJSjHw4YhzV/jwPPdf0Ttu7/XfQ7isysN2VAJmrw6dX+0ly/6Vu+nHq0IO1cnrzmocNYuAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7288
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gao Pan <pandy.gao@nxp.com>

Output error log when i2c peripheral clk rate is 0, then
directly return -EINVAL.

Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index e93ff3b5373c..12b4f2a89343 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
 	lpi2c_imx_set_mode(lpi2c_imx);
 
 	clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+	if (!clk_rate) {
+		dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
+		return -EINVAL;
+	}
+
 	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
 		filt = 0;
 	else
-- 
2.34.1