Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vinod Koul <vkoul@kernel.org>
To:     Kishon Vijay Abraham I <kishon@kernel.org>,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Rob Herring <robh@kernel.org>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        David Yang <mmyangfl@gmail.com>,
        Shawn Guo <shawn.guo@linaro.org>,
        Pengcheng Li <lpc.li@hisilicon.com>,
        Jiancheng Xue <xuejiancheng@hisilicon.com>,
        linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     dan.carpenter@linaro.org, christophe.jaillet@wanadoo.fr,
        julia.lawall@inria.fr, kernel-janitors@vger.kernel.org,
        error27@gmail.com
In-Reply-To: <20230721090558.3588613-1-harshit.m.mogalapalli@oracle.com>
References: <20230721090558.3588613-1-harshit.m.mogalapalli@oracle.com>
Subject: Re: [PATCH] phy: hisilicon: Fix an out of bounds check in
 hisi_inno_phy_probe()
Message-Id: <169019617956.466731.9761851242432174423.b4-ty@kernel.org>
Date:   Mon, 24 Jul 2023 16:26:19 +0530
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Fri, 21 Jul 2023 02:05:55 -0700, Harshit Mogalapalli wrote:
> The size of array 'priv->ports[]' is INNO_PHY_PORT_NUM.
> 
> In the for loop, 'i' is used as the index for array 'priv->ports[]'
> with a check (i > INNO_PHY_PORT_NUM) which indicates that
> INNO_PHY_PORT_NUM is allowed value for 'i' in the same loop.
> 
> This > comparison needs to be changed to >=, otherwise it potentially leads
> to an out of bounds write on the next iteration through the loop
> 
> [...]

Applied, thanks!

[1/1] phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()
      commit: 13c088cf3657d70893d75cf116be937f1509cc0f

Best regards,
-- 
~Vinod