Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: idc5945a3:Fastmail
Message-ID: <81ca146e-986c-b934-3567-2e1267a31ad7@invisiblethingslab.com>
Date:   Mon, 24 Jul 2023 12:29:09 +0200
MIME-Version: 1.0
Subject: Re: [PATCH] xen/events: Add wakeup support to xen-pirq
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20230313134102.3157-1-simon@invisiblethingslab.com>
From:   Simon Gaiser <simon@invisiblethingslab.com>
In-Reply-To: <20230313134102.3157-1-simon@invisiblethingslab.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Hf0VWW22SHCK1Z6ZaG9MPeYj"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Hf0VWW22SHCK1Z6ZaG9MPeYj
Content-Type: multipart/mixed; boundary="------------NM7xgrV6rptQJ4hiPTQm8Yjd";
 protected-headers="v1"
From: Simon Gaiser <simon@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <81ca146e-986c-b934-3567-2e1267a31ad7@invisiblethingslab.com>
Subject: Re: [PATCH] xen/events: Add wakeup support to xen-pirq
References: <20230313134102.3157-1-simon@invisiblethingslab.com>
In-Reply-To: <20230313134102.3157-1-simon@invisiblethingslab.com>

--------------NM7xgrV6rptQJ4hiPTQm8Yjd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Simon Gaiser:
> This allows entering and exiting s2idle. Actual S0ix residency is
> another topic [1].
>=20
> Without this the ACPI code currently ignores the error enable_irq_wake(=
)
> returns when being used on a xen-pirq and the system goes to idle for
> ever since the wakeup IRQ doesn't gets enabled. With [2] the error is
> handled and the system refuses to go to s2idle.
>=20
> Link: https://lore.kernel.org/xen-devel/9051e484-b128-715a-9253-48af8e4=
7bb9d@invisiblethingslab.com/ # [1]
> Link: https://lore.kernel.org/linux-acpi/20230313125344.2893-1-simon@in=
visiblethingslab.com/ # [2]
> Signed-off-by: Simon Gaiser <simon@invisiblethingslab.com>
> ---
>=20
> While I think that the set of flags I set is correct, I'm not familiar
> with that code, so please pay special attention during review if they
> are actually correct for xen-pirq.
>=20
>  drivers/xen/events/events_base.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/even=
ts_base.c
> index c7715f8bd452..991082f04f05 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -2176,6 +2176,10 @@ static struct irq_chip xen_pirq_chip __read_most=
ly =3D {
>  	.irq_set_affinity	=3D set_affinity_irq,
> =20
>  	.irq_retrigger		=3D retrigger_dynirq,
> +
> +	.flags                  =3D IRQCHIP_SKIP_SET_WAKE |
> +				  IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND |
> +				  IRQCHIP_MASK_ON_SUSPEND,
>  };
> =20
>  static struct irq_chip xen_percpu_chip __read_mostly =3D {
ping

--------------NM7xgrV6rptQJ4hiPTQm8Yjd--

--------------Hf0VWW22SHCK1Z6ZaG9MPeYj
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmS+UncACgkQkO9xfO/x
ly9H4w/9H6fMRreUIMniGKL0lM56B1kdKr6WGIfsRP979zHetmBSz0dKKcjJ7e5b
M+ljI+bNMocw/Pq4ph6EKLtrkCjsfH51+44EnZJmDgONbF5kZbxOZc1/YB+WHmWm
qr1eRhq6p7ORtCCRiHdc2Rpr72HMoxc+YDNLhfxdF10j3CVI2jShuEp/hf46zZnM
T3JSVXd1boQo09O2pt6Ka7BjbblfINJ0wT6zNdyhOeBEZMDI5siFP6cddKf+nrAo
2m7CYP7Njgr0IALV1OC4NC39s+qEx7uNzBTVSLJkBpYvyvKC6XfHyJavyaY40MA7
iyeA8hjq6IWCsZ67OcjAokF06ox0xr4ll7H8kx7QAZSwtSTbC+gK4zBgPn/DBAD1
NWj8qHhxFl3oEb/KBZXTg+0JuABbU7ARk/JZhZxR62WZU2hwHMzUViy1hzUvOzty
b1rzZTi3SsSmTaxZOr/vEHBkdde0FYQpLRowLs0v0uUvYB227Ey/HNxr0DJCC6CJ
WhcArncJhkRV+A5kYy47iLJeDMQTElGCRNm1Anm42BMo475b2GT2CWcw0Spnhnnl
pqGSfJISZTQ2HdZmcwFOzDnwBpTcByYsBI5ou5m2/JfRx5UWNGcsxRQaXSAp5IQ4
QelAecD+Fh6LNjnWn3AXXDhBL3o40A+upI4T1prOr74lPjYZudI=
=hLGI
-----END PGP SIGNATURE-----

--------------Hf0VWW22SHCK1Z6ZaG9MPeYj--