Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2955490rwo; Mon, 24 Jul 2023 04:14:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGkW4gsVtBJHn9bGrVUFpS03Pj2GP1xvwDIZMEt2k+J27D506zw7Doe2dhkqOvF1afzCo8h X-Received: by 2002:a17:906:5393:b0:99b:4956:e4df with SMTP id g19-20020a170906539300b0099b4956e4dfmr9226235ejo.11.1690197249170; Mon, 24 Jul 2023 04:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690197249; cv=none; d=google.com; s=arc-20160816; b=XUhoqrIylg7SiU2nzQEG1eObrL4XFoA7jM6eP5bc40gJ1iFVfJbHw29tecDGyPIOdw 2HzUKK//6yQBZ9tNm5zrvg0Rdog5I8pDvsY9r8FRi8u3olN02y5LbpE/0KYZwiWDEx7Z P3NCSNqVQ9okLOxLAkqEdSnZnqZ2Z1gKjOoZw6VPiaTugdcygdoYa57x+Oup+75injD3 TytvlB+ErjWaEPNnIlQ3K4JS63vHa2WBOxxiatwjAqCwX7r4/GuWTUTV4SopT9EKumVg S1ZCAbPoTLne4B48nMTBPSiiqNB9+tbxgfq8wXfq51MWfD7fvi69Vswm513Xd7LWZxcR fFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id; bh=2MulHPWnSfCvA1bw8rEvUW1EVgqUNhL3TbHAAsr03p4=; fh=vwgDnIhqWIrOFbYfka814UqO4hnmI2MtvTYg/ADtI+g=; b=b/TMj3Rk12Oz+o+hoXOGxDaYtJMp+7ONP2vAkg9/I9EupyxfymfryWBoQJ8yoXvbJF nVAeV5agB/YTqQ+mPrHz4eymfF/N1YYQXYD9rP3GiBhgTkXaW0nbG1r/FblHJSPSmkUq efK/GojprcFvVLwpB9IkUEBWaLX7lvX93tF6zZc/fJHaY0D+/cMFFLXRdJnfNAcVSOPu UE55G4V14tvvsfuGfIbquPm+NeFNlz70Q03/Gqz1922jBHo+1spG1/FK6vaa/YLLQXd+ CuhtdQoDPQaKKEfb512trG0RGWj9Cbx+Q+3wMRJ7iMd7sRXwAcAsq5BU4bGPpFOQaaEA slUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mj19-20020a170906af9300b009888665e53fsi6182095ejb.190.2023.07.24.04.13.44; Mon, 24 Jul 2023 04:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbjGXKYG (ORCPT + 99 others); Mon, 24 Jul 2023 06:24:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233508AbjGXKXK (ORCPT ); Mon, 24 Jul 2023 06:23:10 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ACC249D0; Mon, 24 Jul 2023 03:16:53 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0988C24E35D; Mon, 24 Jul 2023 18:16:52 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 24 Jul 2023 18:16:52 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 24 Jul 2023 18:16:51 +0800 Message-ID: Date: Mon, 24 Jul 2023 18:16:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 0/4] StarFive's Pulse Width Modulation driver support Content-Language: en-US From: William Qiu To: , , , CC: Thierry Reding , Philipp Zabel , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Emil Renner Berthing , Hal Feng References: <20230601085154.36938-1-william.qiu@starfivetech.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/27 15:46, William Qiu wrote: > > > On 2023/6/1 16:51, William Qiu wrote: >> Hi, >> >> This patchset adds initial rudimentary support for the StarFive >> Pulse Width Modulation controller driver. And this driver will >> be used in StarFive's VisionFive 2 board.The first patch add >> Documentations for the device and Patch 2 adds device probe for >> the module. >> >> Changes v2->v3: >> - Rebased to v6.4rc3. >> - Sorted the header files in alphabetic order. >> - Changed iowrite32() to writel(). >> - Added a way to turn off. >> - Moified polarity inversion implementation. >> - Added 7100 support. >> - Added dts patches. >> - Used the various helpers in linux/math.h. >> - Corrected formatting problems. >> - Renamed dtbinding to 'starfive,jh7100-pwm.yaml'. >> - Dropped the redundant code. >> >> Changes v2->v3: >> - Fixed some formatting issues. >> >> Changes v1->v2: >> - Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'. >> - Dropped the compatible's Items. >> - Dropped the unuse defines. >> - Modified the code to follow the Linux coding style. >> - Changed return value to dev_err_probe. >> - Dropped the unnecessary local variable. >> >> The patch series is based on v6.4rc3. >> >> William Qiu (4): >> dt-bindings: pwm: Add StarFive PWM module >> pwm: starfive: Add PWM driver support >> riscv: dts: starfive: jh7110: Add PWM node and pins configuration >> riscv: dts: starfive: jh7100: Add PWM node and pins configuration >> >> .../bindings/pwm/starfive,jh7100-pwm.yaml | 55 +++++ >> MAINTAINERS | 7 + >> .../boot/dts/starfive/jh7100-common.dtsi | 24 +++ >> arch/riscv/boot/dts/starfive/jh7100.dtsi | 9 + >> .../jh7110-starfive-visionfive-2.dtsi | 22 ++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 9 + >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-starfive-ptc.c | 192 ++++++++++++++++++ >> 9 files changed, 328 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/starfive,jh7100-pwm.yaml >> create mode 100644 drivers/pwm/pwm-starfive-ptc.c >> >> -- >> 2.34.1 >> > Hi everyone, > > Could you please help me review this patch series to see if there is > anything that needs to be modified? > Thanks for taking time to review this patch series. > > Best Regards, > William Hi Thierry Reding, Could you please help me review this patch series to see if there is anything that needs to be modified? Thanks for taking time to review this patch series. Best Regards, William