Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2957349rwo; Mon, 24 Jul 2023 04:15:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlHW+PgpcD9/CP6ono0DllwZ5BNpnHIBalfWYtEviR5Ki3JXbTrRQWGUaINM9LGKqb6h1QAR X-Received: by 2002:a05:6402:5175:b0:51d:f0fd:bc80 with SMTP id d21-20020a056402517500b0051df0fdbc80mr9924919ede.17.1690197351301; Mon, 24 Jul 2023 04:15:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690197351; cv=none; d=google.com; s=arc-20160816; b=rEjSxXZAZXJbkAVGSCMQwQzdRam+FrhJxdHk+JQPPqDc07juQVg9fSBRP1Nutva0mV IoQfVQIHoBuT4PnKcrngVsvmoZu577QoUq2LZmoFp/oIKcH0/av20YwdLSWuRjceQ6sF sGHGAN4T5ZgMcTK0qwd2/weMygJVEQ68GfX094K4o8ahcBKez8fe1p5m17p42YY8DF+i ao8Kh1EQohO9y/G4i1HsZyoyoxy49X6T1apxuv+Z2FWWfPwl6n1fYUjVuGLMGekv0u2I M/Unat9WqeYyD9UYvSPWnWP/eqfc45YOJzW5hQUARAja7zLsbVdUPgvcMl124T+2uPj1 6piw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=0FHeBcpBRHagwq56WddcpleQO4Ul3LqBwGp49lQWOeQ=; fh=IFKvaMIk0m3G0tjS1Lli3FK2jqW7rpOirXMNagPXhhc=; b=EwExkMvuDNcqWOVyl/01Q/zzWUa0zrHARbbndxEqEnpTdMxTJMYqV4usjEy1tYzu0C Sx/GjEgHk6+oPe6foyc2FTK5CpEibpWfpnS8jPFgFl7MBFhH49OZzRBKg1Uid6yM3+6b fDYO+WXDWc2PxfMeKrHldBJJgriiZ3HZGmKrK8kE4Z4bVipyqEp2RCPV1yN5q9FOt6wS PORtUmNR32l0tJzIMbNgjGSM03+ZlhxkQ4EBc0pNZ8aSUErzqaFIo5Z3DMKTLVBkCVGm pJmQ5w8/DWS5g39rYTOeefezQFS8hZPj7lPx9weGra0M7i4srevN4Y73ai3B5uWdYGB8 x99w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k954BaFi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm5-20020a0564020b0500b00522203dc06asi2548434edb.125.2023.07.24.04.15.27; Mon, 24 Jul 2023 04:15:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k954BaFi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbjGXKxg (ORCPT + 99 others); Mon, 24 Jul 2023 06:53:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232901AbjGXKxe (ORCPT ); Mon, 24 Jul 2023 06:53:34 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C13B5109; Mon, 24 Jul 2023 03:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690196004; x=1721732004; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=I3RsDyPZmFH/6hLZYAuRnBtWMLHHTvXV7RIFZdVLPwU=; b=k954BaFiN4FXr+SgZd7A3ZLdHpJ4rW+bbG6QbUx0voiJPsvLyKCYjXfJ lc5nNjuLb1tWORwrALuusYAW6C/uGvtklCvmss3dhYs5aOS14RPObS5bv GYG/bXQByCnYa3KI+dZ3VHxnIr72aGfkbHZFqZJ76TvpRSj2xjWdFeA40 gEm55GbRsKTtN1pptgtrPhcTI0kjABBVifhaj+bZe8bD2tTTHymAraq02 uvaL1Ud85X52hxs9MRWNI6rUDkvcC2lQsBjczzF6qN8oqnee5pFQJ92rU O9eTmkw4p7jU3IdheKcMONetf7uDP66Cmn8OL9pPc3tzY37GL5ees/0NX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="453784008" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="453784008" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 03:53:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="839406654" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="839406654" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 24 Jul 2023 03:53:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qNtBp-009TG8-1p; Mon, 24 Jul 2023 13:53:21 +0300 Date: Mon, 24 Jul 2023 13:53:21 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Nuno Sa Subject: Re: [PATCH v2 7/8] iio: core: Move initcalls closer to the respective calls Message-ID: References: <20230721170022.3461-1-andriy.shevchenko@linux.intel.com> <20230721170022.3461-8-andriy.shevchenko@linux.intel.com> <20230723102335.6df07e6d@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230723102335.6df07e6d@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 23, 2023 at 10:23:35AM +0100, Jonathan Cameron wrote: > On Fri, 21 Jul 2023 20:00:21 +0300 > Andy Shevchenko wrote: > > > Move subsys_initcall() and module_exit() closer to the respective calls. > > Why? For this particular set of macros I can see advantages to them being > near the code and to them being in a fairly predictable location (end of > file). > > I think the patch description should make the why argument. The documented case is about exported symbols. Now I looked for the module_*() stuff and there is no consensus between subsystems. Both styles are being documented and used. I think I may drop this. Someone also can investigate the trends, but I won't spend my time on this. Thank you for the review. -- With Best Regards, Andy Shevchenko