Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 13:54:20 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Niklas Cassel <nks@flawful.org>
Cc:     linux-ide@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: WARNING: CPU: 1 PID: 67 at drivers/ata/libata-core.c:1688
 ata_read_log_page+0x173/0x1f0
Message-ID: <20230724115420.GAZL5mbE+tlsq6vOdN@fat_crate.local>
References: <20230722155621.GIZLv8JbURKzHtKvQE@fat_crate.local>
 <ZL5lt+9jo1KrnW9b@flawful.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZL5lt+9jo1KrnW9b@flawful.org>
Precedence: bulk

+ hare.

On Mon, Jul 24, 2023 at 01:51:19PM +0200, Niklas Cassel wrote:
> Hello Boris,
> 
> this is a null pointer dereference,
> because ap->ncq_sense_buf buffer is only allocated when CDL is enabled.
> 
> We are not supposed to fetch sense data for successful NCQ commands when
> CDL is not enabled.
> 
> This is my bad.
> Could you please test and see if this patch solves your problem:
> https://lore.kernel.org/linux-ide/20230723130315.427513-1-nks@flawful.org/

Yap, saw it, thanks.

I'll be able to get to it towards the end of the week.

Will let you know,

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette