Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724105546.1964059-1-carlos.song@nxp.com> <20230724105546.1964059-3-carlos.song@nxp.com>
In-Reply-To: <20230724105546.1964059-3-carlos.song@nxp.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Mon, 24 Jul 2023 09:38:04 -0300
Message-ID: <CAOMZO5A28fNmMRwG6dX8vY2OkgvcmjqAJWQmjTXT9-OkAcYrRw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c
 peripheral clk doesn't work
To:     carlos.song@nxp.com
Cc:     andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de,
        xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com,
        linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 24, 2023 at 7:52=E2=80=AFAM <carlos.song@nxp.com> wrote:
>
> From: Gao Pan <pandy.gao@nxp.com>
>
> Output error log when i2c peripheral clk rate is 0, then
> directly return -EINVAL.
>
> Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
>  drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-=
imx-lpi2c.c
> index e93ff3b5373c..12b4f2a89343 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct =
*lpi2c_imx)
>         lpi2c_imx_set_mode(lpi2c_imx);
>
>         clk_rate =3D clk_get_rate(lpi2c_imx->clks[0].clk);
> +       if (!clk_rate) {
> +               dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");

The subject says 'debug message', but this is an error message.

Please adjust the Subject.