Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bcf97046-e336-712a-ac68-7fd194f2953e@gmail.com>
Date:   Mon, 24 Jul 2023 13:27:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: en-US
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Youling Tang <tangyouling@loongson.cn>,
        Huacai Chen <chenhuacai@loongson.cn>,
        loongarch@lists.linux.dev,
        "bpf@vger.kernel.org >> bpf" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
Subject: re: LoongArch: Add BPF JIT support
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Static analysis with clang scan build on arch/loongarch/net/bpf_jit.h 
has detected a potential issue with the following commit:

commit 5dc615520c4dfb358245680f1904bad61116648e
Author: Tiezhu Yang <yangtiezhu@loongson.cn>
Date:   Wed Oct 12 16:36:20 2022 +0800

     LoongArch: Add BPF JIT support

This issue is as follows:

arch/loongarch/net/bpf_jit.h:153:23: warning: Logical disjunction always 
evaluates to true: imm_51_31 != 0 || imm_51_31 != 0x1fffff. 
[incorrectLogicOperator]
    if (imm_51_31 != 0 || imm_51_31 != 0x1fffff) {


The statement seems to be always true. I suspect it should it be instead:

    if (imm_51_31 != 0 && imm_51_31 != 0x1fffff) {

regards,

Colin