Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3132660rwo; Mon, 24 Jul 2023 06:48:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlFO98vfD0P6O9Oy2gbVshHjWDqrY0pRM6707fywkuNDJYn9flzBIjNHnFm9w5MrN4p7m6KS X-Received: by 2002:a17:906:8a:b0:992:4c42:581c with SMTP id 10-20020a170906008a00b009924c42581cmr9888533ejc.62.1690206498117; Mon, 24 Jul 2023 06:48:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690206498; cv=none; d=google.com; s=arc-20160816; b=TYleebDadFxw0q0Y2n6hZbDyvkJE0MFck+qFSEyayMioP6pFl04ZK9ss5XhqFBVnZe Rr1WdHQh6yPG0/nQybUY42O6q5qHTTji6Fg+1p2T7XTXtfedbOA3pWq7AHCPw+zNcKhB FtHZjW8aangdTFZKGRBDOHgwX4SPGr5YgnQLvx3iHc7i3Ux+Q5bidwOsJicfXM6QNZsW lfHh3bAk7t82Od2RcmCvZzz2TOiV0+yWSDiCq2AeXIC1PgehSA9MHvH/Y9yXWrWQcFch pQ7rJZR06weMwMvFoh7Od/+cw+zA0/FsRmM4Km03aEkbY+7yUShRNjtSjYVhZxjCAicA 5wZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=1t5AYKxWBGS5UIcYUily8whdBGpo1cGe3a+nedmnJoI=; fh=mE3iieUIZLcDfOLIULj9X6/p0bMDPZGFSVRsnyRUnTc=; b=L6NynivUkbndKLrOwfECeCBsGqXWxaGLubIL4hVhYSRzXO0sUzIxIU5/7TA6isHWZs 2P56acHUVVIGgdQEHJD+2oBwmIQyZg4BksW472S337m0VdV+UpA1Eha7gRZKWazzdLyX zc++7QOtUEKjSBa4nnq8Muk/AyXS5dp7AVBKXiAH8V7ahjGq8DCvzS/HMPLUm57llWSh wn7bmEDB/pADN2T1j0iYaiTCH7N395SkS/8MJjhYlkU/sz6C7tBvnr3cHfUh9YBrxiS7 Ipsm7jFcBGsW2h/NQ+uj9BmNoRPlKkKKzXP7lXxKiLUu+dRCVT/TVELusxCQ32onyMy1 eoZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="A/CtNbcm"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay22-20020a170906d29600b0098d807c0e8esi6009968ejb.824.2023.07.24.06.47.53; Mon, 24 Jul 2023 06:48:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="A/CtNbcm"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbjGXNh7 (ORCPT + 99 others); Mon, 24 Jul 2023 09:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbjGXNhZ (ORCPT ); Mon, 24 Jul 2023 09:37:25 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B794B30D6 for ; Mon, 24 Jul 2023 06:36:10 -0700 (PDT) Message-ID: <20230724132047.091525607@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690205697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1t5AYKxWBGS5UIcYUily8whdBGpo1cGe3a+nedmnJoI=; b=A/CtNbcmtsJdNxP3bsj0kmvSm6y+c722SE0bVhgL9VBa0lhUmFoCRMIO5qW4hOqqBQLB/6 KK34e063rtzhvC5ByEDAhguSrzaPXbapT1aQx+83c+pRvod1Sau8jcgX+PVBOreqa2buPa KhlTfGOnOPI7VpTTlpx5TIsPx1CiAgr9ruzCI3MuLilRtWKor482zMuupOeAKokADA+LBP GB6OpoZKM/DlFQoRw/GtczZtyJSTH4evRs8LK8xXWHzh9ETPY0TtJxlr45vuFKqEiMibVt Gp/Abh55C+T/KGoVyy7b6XosZERgoEeWvE8Q8ciAhoSRukwG7/xxKQE8uP7leg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690205697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1t5AYKxWBGS5UIcYUily8whdBGpo1cGe3a+nedmnJoI=; b=pBGixmcBO8VPN2x2M+Tr8ud827n21rnFShioHJirNCMtKjSJItN5K6Iqof//mUEhOlbN2X fEm/thFfXcOby2Dg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross , Michael Kelley , Peter Keresztes Schmidt , "Peter Zijlstra (Intel)" Subject: [patch V2 42/58] x86/apic: Simplify X2APIC ID validation References: <20230724131206.500814398@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 24 Jul 2023 15:34:56 +0200 (CEST) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No point in doing the zero equals unlimited check and if not zero compare against the real number. Unlimited is UINT_MAX. So initialize the variable with UINT_MAX and compare less than or equal. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/x2apic_phys.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/arch/x86/kernel/apic/x2apic_phys.c +++ b/arch/x86/kernel/apic/x2apic_phys.c @@ -8,7 +8,7 @@ int x2apic_phys; static struct apic apic_x2apic_phys; -static u32 x2apic_max_apicid __ro_after_init; +static u32 x2apic_max_apicid __ro_after_init = UINT_MAX; void __init x2apic_set_max_apicid(u32 apicid) { @@ -125,10 +125,7 @@ static int x2apic_phys_probe(void) /* Common x2apic functions, also used by x2apic_cluster */ int x2apic_apic_id_valid(u32 apicid) { - if (x2apic_max_apicid && apicid > x2apic_max_apicid) - return 0; - - return 1; + return apicid <= x2apic_max_apicid; } unsigned int x2apic_get_apic_id(unsigned long id)