Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 16:28:02 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Breno Leitao <leitao@debian.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, leit@meta.com,
        Petr Mladek <pmladek@suse.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] netconsole: Use kstrtobool() instead of
 kstrtoint()
Message-ID: <ZL6KcmKWCI3BtfUn@corigine.com>
References: <20230721092146.4036622-1-leitao@debian.org>
 <20230721092146.4036622-2-leitao@debian.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721092146.4036622-2-leitao@debian.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dE/vTOLLY2yhojdKmMVnzzZDFixGDF9cXVYW+pXO4cruv4iWNs0i2Duod0GP?=
 =?us-ascii?Q?xmTFx1XjbV6uPo10o+gIn4X40CWKM/r+Us2ks/5BABSDY4fL7KPcWTCktXh0?=
 =?us-ascii?Q?t5KO3dVULqUDynG0aK6pMKupqWefLJnWguqhRdgmnar+H62x1m+WIkn1Yrqs?=
 =?us-ascii?Q?FAHUIu6fvadgys/r/zOUVJFVSxKYnqVvkjGpgVpGFyBVCas0T85Gr/xzH8cO?=
 =?us-ascii?Q?cJGcAwo/uhYWJuO4f4mUk8w77+KBVkJYpnCNUsRAcb3JB07s/GuMkU1+Mtwo?=
 =?us-ascii?Q?LgD8xVm2gt3VolUfIWa34N9ICXm5zqruuTqzqPTbXLGdZCmHzQTOziHrL/eB?=
 =?us-ascii?Q?L6R0eqAAESvs4eqQ2BN6UQczOLGFeTIESG95JRkhs4LuWpWfhmSA4JyQRZgb?=
 =?us-ascii?Q?szxi593NL6Q8nixJc5+0+GKqGM6FmieORqBe0npK9ZxPfvlezMKLBFvj/Mop?=
 =?us-ascii?Q?mrrYePH1Krjld3EVAFwGLXfaVL5HrJRztM4CROp+ufZ9GuZq/3gaQ/EDobHF?=
 =?us-ascii?Q?b4PvxROfsqoEnSVY0NmEytXWWZJO4g1Q0ezkDZY5ysI59nMKltPLHlB5Qrpj?=
 =?us-ascii?Q?u+AsPpTB9bsCE8Rxh4PTC7Y2f4qlR47zojBHMEo4P8Tzs6RJAXBbIzUs3jBO?=
 =?us-ascii?Q?l+qjV/rw7Atd+gWRZd74Li3w4+bCpvcdLy1P2eIoThcPAqjiRawBY/M9qN+R?=
 =?us-ascii?Q?gM7bTBs0pWXf22E+AQz7uMGOoF+zJdmrJZkjqVglJ8eO7KD0IkvUpQVmMmtz?=
 =?us-ascii?Q?IvP6KtU0+tq6msmnSDteNMDCREBzUqngIOPz0z5xiwVxXbO9nOrAzd2nRXsw?=
 =?us-ascii?Q?19CeWECc4mTiqxoizdIwvVcRX2jp8M/q5dg4XZtcOdDSjLTTpJRcQcnzQ+2F?=
 =?us-ascii?Q?3nwoxyRcA/VQP/3LjYVM/oQfT/MtJl3cAU+ukfR7+Xo9GsbtQ5Bj2xNvkHJ2?=
 =?us-ascii?Q?f+f9dCeg+2rCkgYlz2UI+EfXV+zbSpHnmxLRWPnIF+q8YyB8idT3bs83V/NA?=
 =?us-ascii?Q?s/XcEFyh72rLcmLCUF75foStdS42YXgfuVlB19KKEB5FxTUni6HdkHGvBjUY?=
 =?us-ascii?Q?Z/PCE7xVO9egtFRju3UTmQlPUWtMsWT6RIMbYZUQuqa82WzY48igN7NwHw7N?=
 =?us-ascii?Q?+I9iR5j9YZrTlAUWvUvehfbREuBQEt6Vi8A3zCj1nQuPvEV23j5m66ZUn7WA?=
 =?us-ascii?Q?IqhsXgkQmcRXDzk2ThtbtQ/JfM+LbYOuI49HAxNVR2ppXBXeNtbHHpRvFHEx?=
 =?us-ascii?Q?UEUxud9kt97mzS2VaOsGr2rvpMnvYikGv8XScgHCPyM2zIzDyjsD189/QiFx?=
 =?us-ascii?Q?wNynRAO80lS/co9MbQuJWY3I0ZRJYoSR89oGJkQbB9OrAoSgdZxIG55JPSXX?=
 =?us-ascii?Q?42+Dg2/5x8HUzPZh/CbGBGYai5CyztXGc4F4BVoyeeb8ygvZsnc1as1Qi0ZA?=
 =?us-ascii?Q?uPLE46KARqF+OPzAxRSEvT/wThCRXxd7+MHtDaKLXfzt4oxDoSH1IlnH3p0F?=
 =?us-ascii?Q?8Nb9t6QPKyrg9ddk4o2IZPLUhboPAqiGjOmm+0jHnK7DE9d5qPnzR3H3QOND?=
 =?us-ascii?Q?YcMQ/6jeeFN67WibD3RvcrQJphC0gkwkrc4jy6Ws0s7ZHgckwTkjV8Ddrdkd?=
 =?us-ascii?Q?30XwpLpH4MWWhjg+ImC6ab41vSjKSBk34vl47ew8lymjAQwZdZP1q8mITCTg?=
 =?us-ascii?Q?kDusng=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0497af62-ec42-4fc9-7cdf-08db8c523374
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 14:28:08.3066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5w1nM2rXzgypual5wAA6dFmBdWt1T13u93B6FS5zwItTv1GWOJUxEVryQ5UUbexr9x/Xk+Vo1qsOPFvfhaVaFC73+m7SpC6TpXmhyCc9gOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5602
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2023 at 02:21:45AM -0700, Breno Leitao wrote:
> Replace kstrtoint() by kstrtobool() in the sysfs _store() functions.
> This improves the user usability and simplify the code.
> 
> With this fix, it is now possible to use [YyNn] to set and unset a
> feature. Old behaviour is still unchanged.
> 
> kstrtobool() is also safer and doesn't need the extra validation that
> is required when converting a string to bool (end field in the struct),
> which makes the code simpler.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>