Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 16:27:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Breno Leitao <leitao@debian.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, leit@meta.com,
        Petr Mladek <pmladek@suse.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] netconsole: Use sysfs_emit() instead of
 snprintf()
Message-ID: <ZL6KQLUNIyXHAtOy@corigine.com>
References: <20230721092146.4036622-1-leitao@debian.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721092146.4036622-1-leitao@debian.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dy+ru3CN66ODHpKBZUPpLU8Rwpg4WxacuAuARCWZPFGjh+vrw54H8n1QXbF2?=
 =?us-ascii?Q?usN9MkGydNgy7SUv+32gUvERsbaaB41xNN3hrH+CPWuyTR0S46Nq/c4wueVl?=
 =?us-ascii?Q?oMGn+ltrGJekr21k/7hniuZ+EA/yeHJ8EGuOv4/obwSSBbsPDMhXBVdkJ84G?=
 =?us-ascii?Q?es/ksOvoqfsd0c7unAFOuwmfQCTLvd2oWxWnYmoC8koRgnkcEVvWybMo3soq?=
 =?us-ascii?Q?He7BQ9nYHmTQIZDtA1R4kYistnDk/1d2DmvXxk0X4pvAy5eXSAM3gToI3zhn?=
 =?us-ascii?Q?kJxwX3EhMkRsnzWlMOR6awleViTpSDBngpKBqC5zlYhLFJN1pHVhEYbsMpJI?=
 =?us-ascii?Q?agzny1R9dNqT/W7fKhYs4mIjUj+NEfcchTd+zdf6v0Jzamn14GJ0Kdm/+fpY?=
 =?us-ascii?Q?BDj/DkaHnt1fuSdDbjGJ+XgLP8/VE7VSPyiN3+dGLoteWEtqdi+CqbxAm90F?=
 =?us-ascii?Q?vAK/Z3WwTMwLW0JteGz+HaGwY37Ee7sGW+FSQx8t4TfpzyBfNZjEkhjZIBpG?=
 =?us-ascii?Q?CW5ASGYEBkRMU5WitGMVV2ka+1Qk9y6upS4SRBJR97wqHllmFibL2GpJz5d7?=
 =?us-ascii?Q?R00a6+NQWRuOA1bBXx3afpiWSc4bRqbDSbOz4VwSf6rbtn730vmoLcFDCO+8?=
 =?us-ascii?Q?KQSTECy1/BZ3xwTGMDgRrhOvcz26iyTEh01moCnvK6vByBzhTBy0cBrXlWAl?=
 =?us-ascii?Q?S/BLgi7Z1Z8vCgvLdkC+6oKkZU4tCABRS7VNXR12JdS+NHjMW4jHuc8t8ey7?=
 =?us-ascii?Q?BRLTgpe0W2T3DqS4I5UXWzRZa9aIDyOONVbpX1SIpQkaRTYocUrx7d/Q+aAs?=
 =?us-ascii?Q?s8iohUCQ0yE7MvpuMO4KUJVx/V9mrsSletjWDkpI7Ihas2ezWlTi7vRdXsmy?=
 =?us-ascii?Q?comVU8I1NhtRjirtuWPrCsFJiyzQ7bdTRHJYgB3Oq+V69VMEJ3u7/6HtvqP2?=
 =?us-ascii?Q?jCFw9lLL7cDl5lBlRCc3GuBF9HHJ1GSo7OJmAKBp3z9Qry9Mf4StiVQPg5ex?=
 =?us-ascii?Q?0tU+u1w0/m19WDgiDrGeQgi1M5uE6GndSW3oT0iobiEQcmi9FdRXXsHpjC+g?=
 =?us-ascii?Q?HW+BE50bruCDuN4RnhSZcYAFh88pAU4Q+7d1NuGAZJosEOlH9CPfbfpjSqOZ?=
 =?us-ascii?Q?4vTFDOXZ+h+ugUC2UsUnf/pWMrzFKMCmGt0Hv+0Bi1at4569Xt6EqG0kGTI1?=
 =?us-ascii?Q?rvDxcJifxowwduQ/TvQoX/WP1B83bMTUAsbZVcDlHhL3K9uWzFFxu07N1hIj?=
 =?us-ascii?Q?Eg/ePmBMA/7jMegDrzdKwvsu8Xv1uKXyfpwiK5VnXFEnTLFUUqmNFqEpWadH?=
 =?us-ascii?Q?2qTqlw0IHwkEdz6B30vU39S5IDF5MW+XVCRyNk7BK2IDxhLqVS9odagD5mAo?=
 =?us-ascii?Q?F97ev+V7ym6aC9gbvNbByzRuFEU5h8p1ON89zB/xkEdT5dNogeNN0GQWf/p+?=
 =?us-ascii?Q?WjgE0ac3Zg9lYcmXjPiDRoi4Z/CWgjW2Kp7YLCmJKnNvCpMnAaCS4VHf145a?=
 =?us-ascii?Q?kCHw4CHNYN5DCchGcY4VDgBH61l4e62cihr009l9QgQLPhNbsCbF2zvwwFDE?=
 =?us-ascii?Q?5hJ59LeRM+R+9xz4do7vqTzkyqfTAt9e4tpjQcnKgE1gcXV8vd14dhASxxmr?=
 =?us-ascii?Q?pR7z9CKaKZjP7CS6mFn1oG2UWnlWc/uHgHQyIXrfu3SNAvxyEQ1MS0FYk5Qm?=
 =?us-ascii?Q?1vbmEw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39e5e8ae-e1f3-4cca-55ea-08db8c521611
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 14:27:19.0546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bpbCkLG52u5fMvIHC3Hjrf/cYpG7ApQT/u3Km0gP8t2Tyo7Z2f/DYbm2vXKvqAw7J+krR0whDQ11hot3K4A2JilKu/bU/Tpijrh2Qkmu7os=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB5030
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2023 at 02:21:44AM -0700, Breno Leitao wrote:
> According to the sysfs.rst documentation, _show() functions should only
> use sysfs_emit() instead of snprintf().
> 
> Since snprintf() shouldn't be used in the sysfs _show() path, replace it
> by sysfs_emit().
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>