Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <7854000d2ce5ac32b75782a7c4574f25a11b573d.1689757133.git.jstancek@redhat.com>
 <64434.1690193532@warthog.procyon.org.uk>
In-Reply-To: <64434.1690193532@warthog.procyon.org.uk>
From:   Jan Stancek <jstancek@redhat.com>
Date:   Mon, 24 Jul 2023 16:51:11 +0200
Message-ID: <CAASaF6yKxWaW6me0Y+vSEo0qUm_LTyL5CPVka75EPg_yq4MO9g@mail.gmail.com>
Subject: Re: [PATCH] splice, net: Fix splice_to_socket() for O_NONBLOCK socket
To:     David Howells <dhowells@redhat.com>
Cc:     kuba@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, brauner@kernel.org,
        viro@zeniv.linux.org.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 24, 2023 at 12:12=E2=80=AFPM David Howells <dhowells@redhat.com=
> wrote:
>
> Jan Stancek <jstancek@redhat.com> wrote:
>
> > LTP sendfile07 [1], which expects sendfile() to return EAGAIN when
> > transferring data from regular file to a "full" O_NONBLOCK socket,
> > started failing after commit 2dc334f1a63a ("splice, net: Use
> > sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()").
> > sendfile() no longer immediately returns, but now blocks.
> >
> > Removed sock_sendpage() handled this case by setting a MSG_DONTWAIT
> > flag, fix new splice_to_socket() to do the same for O_NONBLOCK sockets.
>
> Does this actually work correctly in all circumstances?
>
> The problem might come if you have a splice from a non-rewindable source
> through a temporary pipe (eg. sendfile() using splice_direct_to_actor()).

I assumed this was safe, since sendfile / splice_direct_to_actor()
requires input to be seekable.