Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf089185-4696-40ce-42c9-df2eea336d05@gmail.com>
Date:   Mon, 24 Jul 2023 08:35:14 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs
Content-Language: en-US
To:     Tristram.Ha@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1689900053-13118-1-git-send-email-Tristram.Ha@microchip.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <1689900053-13118-1-git-send-email-Tristram.Ha@microchip.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/20/2023 5:40 PM, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <Tristram.Ha@microchip.com>
> 
> Microchip LAN8740/LAN8742 PHYs support basic unicast, broadcast, and
> Magic Packet WoL.  They have one pattern filter matching up to 128 bytes
> of frame data, which can be used to implement ARP or multicast WoL.
> 
> ARP WoL matches any ARP frame with broadcast address.
> 
> Multicast WoL matches any multicast frame.
> 
> Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>

This looks good to me, just one suggestion but which you can implement 
later, it would be nice to have a pm_wakeup_event(&phydev->mdio.dev, 0) 
in order to have the PHY device accounted for any wake-up event. You can 
do that when you do the initial acknowledgement of any wake-up 
interrupts in your .config_init callback.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian