Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42044653-cc22-131a-bf1b-e68ddfa0ff9d@ti.com>
Date:   Mon, 24 Jul 2023 11:06:24 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes
To:     Francesco Dolcini <francesco@dolcini.it>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Francesco Dolcini <francesco.dolcini@toradex.com>
References: <20230724133612.37366-1-francesco@dolcini.it>
 <20230724133612.37366-2-francesco@dolcini.it>
Content-Language: en-US
From:   Judith Mendez <jm@ti.com>
In-Reply-To: <20230724133612.37366-2-francesco@dolcini.it>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Francesco,

On 7/24/23 8:36 AM, Francesco Dolcini wrote:
> From: Judith Mendez <jm@ti.com>
> 
> On AM62x there are no hardware interrupts routed to A53 GIC
> interrupt controller for MCU MCAN IPs, so MCU MCAN nodes were
> omitted from MCU dtsi.
> 
> Timer polling was introduced in commits [1][2] so now add MCU MCAN nodes
> to the MCU dtsi for the Cortex A53.
> 
> [1] b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
> [2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN")
> 
> Signed-off-by: Judith Mendez <jm@ti.com>
> [fd: fixed labels to match datasheet numbering, revised commit message,
>       fixed reg/reg-names order]
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> index 19fc38157d94..fed50666d95b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> @@ -147,4 +147,28 @@ mcu_rti0: watchdog@4880000 {
>   		/* Tightly coupled to M4F */
>   		status = "reserved";
>   	};
> +
> +	mcu_mcan0: can@4e00000 {
> +		compatible = "bosch,m_can";
> +		reg = <0x00 0x4e08000 0x00 0x200>,
> +		      <0x00 0x4e00000 0x00 0x8000>;
> +		reg-names = "m_can", "message_ram";
> +		power-domains = <&k3_pds 188 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 188 6>, <&k3_clks 188 1>;
> +		clock-names = "hclk", "cclk";
> +		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +		status = "disabled";
> +	};
> +
> +	mcu_mcan1: can@4e10000 {
> +		compatible = "bosch,m_can";
> +		reg = <0x00 0x4e18000 0x00 0x200>,
> +		      <0x00 0x4e10000 0x00 0x8000>;
> +		reg-names = "m_can", "message_ram";
> +		power-domains = <&k3_pds 189 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 189 6>, <&k3_clks 189 1>;
> +		clock-names = "hclk", "cclk";
> +		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +		status = "disabled";
> +	};
>   };

Thanks for sending this patch, will also send for AM62ax.

~ Judith