Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3355147rwo; Mon, 24 Jul 2023 09:45:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGP5cCGb/bnxAqYTWwGsmMNjMcQvMF3SvRM/lODDiO+5f87NTpFfeyiuNl7JS75YjqI9Txz X-Received: by 2002:a05:6a20:2450:b0:11e:e940:441e with SMTP id t16-20020a056a20245000b0011ee940441emr8684929pzc.25.1690217146830; Mon, 24 Jul 2023 09:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690217146; cv=none; d=google.com; s=arc-20160816; b=oxn5GqrFlnW6jf2s33B2QbFMc07RXm0oVOeaVChZ1v8eMo4oryi9uuD3GWZ6pwEtDA fresJjhscjuv/ewm2Vu/SQUCPakmWmcZi6d5KQCQs/4DhHH69ZSzzOWSlp4SObzfRWC7 Xr/zYoHX7r3+qmeE8YvdjAgrq2vSVRLNzx1273lgplLQdtSAps/4vyz4+BGmohAMicDU Tlj1KStskLgocb9O6jzldSYlrSucj/qL4oOL3aj6izyn7X9LH+rRJwsl1tYNFdRQCQnl CWF6FfB7oOkTYarYepPIgQMe20J0QyWBuuZwI9EZyALphXOiVybnpKjHBDWOlRB1CVSH gJzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=RvPju9UecviXiaOzgyy4f97iyrnfpdgE7f1YC76j9q8=; fh=XRgBlRL4R2rWx4G6CM68w5Zb82nA2m9/qv0wBjmbHGc=; b=oKS3sUwWO6OSfs2sAJc/HKqXps++eNexzSKkRrZdxciXpfJHumvHlrTDUZi+1KSg1Y nrJZJ9uYsg24xqBqiHxB588agcAQhkT9xFt6N96lih1KBAtat6i2JxSs48wcTS+cmmdy fko1bvaYSNpWAsuaH4HmNMJZClvEHfpm0Tz3O0VMcj5z3S+cysEBnu0rcPyxjE+1/yW6 YYVR44G8PA/4PYpEz9RFNB0PJy6Qkffs0dxtxdJ3Vc3i56khnTqHWnlKAOp5WJYIYC1b uKFTQ1ytmyeY5xQLUdn2l55U42XXons3mXhA2pqPOSBC1DUMNb+eB98PMxjpDUbgwqLS Q+cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JoMqX5D7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a16-20020a170902ecd000b001b9d8ea026fsi10112691plh.485.2023.07.24.09.45.34; Mon, 24 Jul 2023 09:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JoMqX5D7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230461AbjGXQQ4 (ORCPT + 99 others); Mon, 24 Jul 2023 12:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbjGXQQx (ORCPT ); Mon, 24 Jul 2023 12:16:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E75FF10C1 for ; Mon, 24 Jul 2023 09:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690215367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RvPju9UecviXiaOzgyy4f97iyrnfpdgE7f1YC76j9q8=; b=JoMqX5D7F6hBss5jeQawz0VxhR++6mCq25rUrYDTtFnrja+mInhZk5v0Da0jpIHfvYsGiI ojXSWtXYTGNQhRR/Qzr/3AKt86pUP8Rk4m/jC1LcGhdChNNZLGdW4yPnncNYbZjbp9a4aL l/gLzJNDIHTh7o31ABVfEIK8sIelf10= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-91KBanixNt-l4k_5d6stQg-1; Mon, 24 Jul 2023 12:16:03 -0400 X-MC-Unique: 91KBanixNt-l4k_5d6stQg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6084E85A58A; Mon, 24 Jul 2023 16:16:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 766D8492C13; Mon, 24 Jul 2023 16:15:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230629155433.4170837-1-dhowells@redhat.com> <20230629155433.4170837-2-dhowells@redhat.com> <63041.1690191864@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Linus Torvalds , Matthew Wilcox , Matt Whitlock , netdev@vger.kernel.org, Dave Chinner , Jens Axboe , linux-fsdevel@kvack.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12728.1690215357.1@warthog.procyon.org.uk> Date: Mon, 24 Jul 2023 17:15:57 +0100 Message-ID: <12729.1690215357@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Both source and destination of copy_file_range() are regular files and Ah - the check is in generic_file_rw_checks(). Okay, nevermind. (Though it looks like it might allow this to be used with procfiles and suchlike, but anyone who tries that had probably better know what they're doing). David