Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3391659rwo; Mon, 24 Jul 2023 10:15:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlEr1l4ta1djDO7pxfWKuY3C29QPsVcVS++i2Pu/rUp5KPzRyoy+iVd8Q2ZMDjGGgPJXPZrd X-Received: by 2002:a17:907:75e2:b0:99b:4bab:2841 with SMTP id jz2-20020a17090775e200b0099b4bab2841mr11083842ejc.26.1690218958192; Mon, 24 Jul 2023 10:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690218958; cv=none; d=google.com; s=arc-20160816; b=TAc5GM0CmKalpSDYlYZ7ohP/X3MAPFLCb8UN9awm60gqVtgvXpqkoeNz+hUNV1w1fy gXQRK7iJb6xSdsj6G5MIXBQnPrXV+mp2Qr/aB8/syYJoiICRsPsj/bRnidfFVcQKW33w YA1VzwT4/WTHcbDWsJ+cHX/1CwPX6GAsxuZHfQ7zq1OyMov233otGT/UyDInZkGwuyiO 7sFEPHQO+clJZK5BaONce3tU31xAxe5QTFXLVD8qo+OFmD9WnrvGDBsa9CLJE0s8edz+ 4gxSsLZBgQSnbxpe1w4mIg0spmHFsuqj88yv7D/wYJ7fjhw1HkVQjVO2n6OGtIQHw7ru NKZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fuO69EeQfpSsvOlfZGqys81+wCiHKgvhYlMrUNviNzw=; fh=HsBY4W1+JKq+XKXfv+LxkSnkN5qZrrOmvh6aitKra6U=; b=Jnakeu8qDr5Ob0Yn613rRo+I19+DHg6OYTOwkcNq3p1tQhwco/8yAj5nJOE5VSV94C cN4BhlzstIJBbzYplXdfzXO8GFD1jx+jWz1QEmAG5zyq/jZvrsvRGNUyOeeNgLKLlbSn GjHOy9y5w/VkS3ySYyAx3iGTUSIyakptAImxDIOy/y8u1mHAqEbSs4jELQ0Hn7DN44ZD MTUESu2nqNyuYp/KMi0ywUcH0twH0E//Fe/BBmaEDzwaKzqPoP9vgwBUu66KPXfw9WtE j6Y+w5nK0cougdDgcjz3H0Q4IdLUUqOFrNkWk3l0oFIKPGDOAL9wSgeUYg79AEl6MiWr TP8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MUF9/S8x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw26-20020a170906fcba00b0098e0739532fsi6691478ejb.732.2023.07.24.10.15.33; Mon, 24 Jul 2023 10:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MUF9/S8x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbjGXQoQ (ORCPT + 99 others); Mon, 24 Jul 2023 12:44:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbjGXQoP (ORCPT ); Mon, 24 Jul 2023 12:44:15 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD5C6E4F; Mon, 24 Jul 2023 09:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690217054; x=1721753054; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lMaCEtlky6+G2Qml4d+2fh4hc1YJEldCNV0Yg/t8zMo=; b=MUF9/S8xziIrwYRyjOhgwsBoRPTDzG1pX+onfQlfJi+xWmOEjmx9cK5m UNP4JzrozE5LZSndxSnLkpwseVr5rDSrhtsqvpvsq93BPk2tOH6PcMwkR SI6yKOU4oY8VAH3ACL5l5d4/sroot2UocpWZkZjh4XQ5AjV30ShzNJ8IC TZsAJyhtuSR+aoWitfjSOMveuLMAhsjA/ByLnoTbWbrZI5KL+XOigGixD WheTQnf+XKzZxBxl6sw39mGtZwMmwC87ir19s3v5Ni2UR8bf6lRav2aPJ KIwQZ/2rbCHJorN2dBWhG2xwAs+WU/zyiEoXzLUK/B1AroVIM5p0eo0ww g==; X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="370160610" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="370160610" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 09:44:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="791028212" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="791028212" Received: from gionescu-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.34.175]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 09:44:10 -0700 Date: Mon, 24 Jul 2023 18:44:07 +0200 From: Andi Shyti To: Christophe JAILLET Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Matthew Auld , Maarten Lankhorst , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix an error handling path in igt_write_huge() Message-ID: References: <7a036b88671312ee9adc01c74ef5b3376f690b76.1689619758.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a036b88671312ee9adc01c74ef5b3376f690b76.1689619758.git.christophe.jaillet@wanadoo.fr> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, > All error handling paths go to 'out', except this one. Be consistent and > also branch to 'out' here. > > Fixes: c10a652e239e ("drm/i915/selftests: Rework context handling in hugepages selftests") > Signed-off-by: Christophe JAILLET Pushed to drm-intel-gt-next. Thanks, Andi