Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 12:55:53 -0400
From:   Hamza Mahfooz <someguy@effective-light.com>
Subject: Re: [PATCH] HID: logitech-hidpp: add support for the Logitech G Pro X
 mouse
To:     linux-kernel@vger.kernel.org
Cc:     Filipe =?iso-8859-1?b?TGHtbnM=?= <lains@riseup.net>,
        Bastien Nocera <hadess@hadess.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org
Message-Id: <5D8BYR.57BKDP2Y14951@effective-light.com>
In-Reply-To: <20230724163032.15226-1-someguy@effective-light.com>
References: <20230724163032.15226-1-someguy@effective-light.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk


On Mon, Jul 24 2023 at 12:30:32 PM -04:00:00, Hamza Mahfooz 
<someguy@effective-light.com> wrote:
> The Logitech G Pro X mouse uses the HID++ protocol and supports 
> battery
> reporting. So, add it to the list of supported devices.
> 
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>

Actually on further inspection there is already a series that address
this issue (i.e.
https://lore.kernel.org/r/20230716182320.85483-1-mavchatz@protonmail.com/),
so please ignore this patch.

> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c 
> b/drivers/hid/hid-logitech-hidpp.c
> index 129b01be488d..34fc4f7b254a 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4620,6 +4620,8 @@ static const struct hid_device_id 
> hidpp_devices[] = {
>  		.driver_data = HIDPP_QUIRK_CLASS_G920 | 
> HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
>  	{ /* Logitech G Pro Gaming Mouse over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
> +	{ /* Logitech G Pro X Superlight Gaming Mouse over USB */
> +	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC094) },
> 
>  	{ /* G935 Gaming Headset */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0x0a87),
> --
> 2.41.0
>