Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <34652b37-9e71-8f23-bd0b-12b6a8faa81b@roeck-us.net>
Date:   Mon, 24 Jul 2023 10:53:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch 05/29] hwmon: (fam15h_power) Use topology_core_id()
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
        Huang Rui <ray.huang@amd.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        James Smart <james.smart@broadcom.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, Steve Wahl <steve.wahl@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>
References: <20230724155329.474037902@linutronix.de>
 <20230724172843.988600888@linutronix.de>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230724172843.988600888@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/24/23 10:43, Thomas Gleixner wrote:
> Use the provided topology helper function instead of fiddling in cpu_data.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-hwmon@vger.kernel.org
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Assuming this will be applied as part of the series:

Acked-by: Guenter Roeck <linux@roeck-us.net>

Please let me know if you want me to apply the patch through
the hardware monitoring branch.

Thanks,
Guenter

> ---
>   drivers/hwmon/fam15h_power.c |    7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- a/drivers/hwmon/fam15h_power.c
> +++ b/drivers/hwmon/fam15h_power.c
> @@ -17,6 +17,7 @@
>   #include <linux/cpumask.h>
>   #include <linux/time.h>
>   #include <linux/sched.h>
> +#include <linux/topology.h>
>   #include <asm/processor.h>
>   #include <asm/msr.h>
>   
> @@ -134,15 +135,13 @@ static DEVICE_ATTR_RO(power1_crit);
>   static void do_read_registers_on_cu(void *_data)
>   {
>   	struct fam15h_power_data *data = _data;
> -	int cpu, cu;
> -
> -	cpu = smp_processor_id();
> +	int cu;
>   
>   	/*
>   	 * With the new x86 topology modelling, cpu core id actually
>   	 * is compute unit id.
>   	 */
> -	cu = cpu_data(cpu).cpu_core_id;
> +	cu = topology_core_id(smp_processor_id());
>   
>   	rdmsrl_safe(MSR_F15H_CU_PWR_ACCUMULATOR, &data->cu_acc_power[cu]);
>   	rdmsrl_safe(MSR_F15H_PTSC, &data->cpu_sw_pwr_ptsc[cu]);
>