Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [net 1/2] net: ethtool: Unify ETHTOOL_{G,S}RXFH rxnfc copy
To:     Joe Damato <jdamato@fastly.com>, netdev@vger.kernel.org,
        saeedm@nvidia.com, tariqt@nvidia.com, ecree@solarflare.com,
        andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net,
        leon@kernel.org, pabeni@redhat.com, bhutchings@solarflare.com,
        arnd@arndb.de
Cc:     linux-kernel@vger.kernel.org
References: <20230723150658.241597-1-jdamato@fastly.com>
 <20230723150658.241597-2-jdamato@fastly.com>
From:   Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <6f7e5c45-9961-3ac2-69ae-434191c9e11c@gmail.com>
Date:   Mon, 24 Jul 2023 20:27:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20230723150658.241597-2-jdamato@fastly.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/07/2023 16:06, Joe Damato wrote:
> ETHTOOL_GRXFH correctly copies in the full struct ethtool_rxnfc when
> FLOW_RSS is set; ETHTOOL_SRXFH needs a similar code path to handle the
> FLOW_RSS case so that ethtool can set the flow hash for custom RSS
> contexts (if supported by the driver).
> 
> The copy code from ETHTOOL_GRXFH has been pulled out in to a helper so
> that it can be called in both ETHTOOL_{G,S}RXFH code paths.
> 
> Fixes: 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches")
> Signed-off-by: Joe Damato <jdamato@fastly.com>

Acked-by: Edward Cree <ecree.xilinx@gmail.com>