Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3563041rwo;
        Mon, 24 Jul 2023 13:02:05 -0700 (PDT)
X-Google-Smtp-Source: APBJJlE/r+gX53ltczGJrd9fJtF3gl5Ocfxev2JKWBcAI4Ikki7bFNU84rZLD15eAejh3gPJN3Pw
X-Received: by 2002:a17:902:e884:b0:1b8:b442:aa97 with SMTP id w4-20020a170902e88400b001b8b442aa97mr11286773plg.54.1690228924201;
        Mon, 24 Jul 2023 13:02:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1690228924; cv=none;
        d=google.com; s=arc-20160816;
        b=e6Ut2CYGfft6CBKysB+RrcevxqqVvkQThH1vWe2u1joJmizjNUDFY/I6AHYDSRFvR8
         xZ2mTfOJW5hRFWarcjvXKzhnG7xPG5dwEApDsxXtUQKsh0ml6ck5w9kYpUZsaVhpQLRh
         IXy5z8UcAI5mHkR1HE6lXSGK6F638/6j+Vps0243LnarD7o9ABh8AQAN3mlu5zJzFKJP
         +csQ2wrzoyzhn4YEOCWGw/UPcvfQ9BCSJQ0mGFY8uKABwipZ2Y7b1sAC3QyJhdcZrnBl
         wn+W5d5gASRbOLghD4NQBz0G6rmoMq8ds74ky3hhJZc431uuLFcUdVo8vMvupiEAfhKG
         SQWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=vdG/qNSKAzMCne6hs3LuiSYA/9ObGKKt85CSCwfqp+8=;
        fh=+QmlZwWFsiRq/+iEZXod2XzTeEk8UoLMI4fSK6R8UcQ=;
        b=vo6tPaCc/E6jJK4mDJC/BbE5xrWg0s5Pu3NuJ9w5a77ShPAty+H472SR5xDu8QHJv5
         d+nDAvbHGjZEfPEAQrBa4MK8eta7XgOuFlUMLduLFZigv5gy88iJOy11MhI2uIKLeeYy
         PlE1QPTNBeaQ1vYAyv6ccZMJ4nJ/VUPx03l9VZhkYvTaMHtCDaImOD8fF6VZj6bi49Wm
         0SR8CUlOekYhkrABp4FyzUBdImXhrzPtegw6X3nc+JWGpKTAs7jLVWYGtL9b234vmXga
         Hwpz9hRV3NVnEsKrQ1gdAVa6sFk3S+dErWrOBxDjYB5WE5xZMjFL294BW4B3hJwT2sSI
         vSMA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lo5vCN0P;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id q18-20020a170902e31200b001b828f8dd13si8951179plc.340.2023.07.24.13.01.50;
        Mon, 24 Jul 2023 13:02:04 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lo5vCN0P;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230110AbjGXTzT (ORCPT <rfc822;andreqb@gmail.com> + 99 others);
        Mon, 24 Jul 2023 15:55:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50152 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229552AbjGXTzS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2023 15:55:18 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28CDF171B;
        Mon, 24 Jul 2023 12:55:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=vdG/qNSKAzMCne6hs3LuiSYA/9ObGKKt85CSCwfqp+8=; b=Lo5vCN0PICFy6ElN9FzwxzcyT6
        7YJ6rFItX/cYTsSesVk8KecuQbeNAINLKOV3oZlEXpxacWvJ1/fJ/mEKrfYTtgn3vG25lSW5INIcE
        PR/Ygv2r8wxwQNoCMmPV0AMuOuq70/Fgo1PQP/q9HuX83lOk8eMIq7nNGwPBGvXLM9HUyTQrZYhZP
        TU1unPlfOoex8HJhdrzkerKgTClh3BDodQqKgGchzLpYrforw30e84WAfgMyJfK49cYkq3nbMUZYT
        +px7X36aw2QkJ8Sfg31jHyIyDVVneeD8XtR1rls9kwupX+qEFNTISZQw1h8WNkvj8bugHCERVTCXh
        vbLJoDvQ==;
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1qO1eF-005Kws-0A;
        Mon, 24 Jul 2023 19:55:15 +0000
Date:   Mon, 24 Jul 2023 12:55:15 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jens Axboe <axboe@kernel.dk>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Christian Brauner <christian@brauner.io>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return
Message-ID: <ZL7XI7wFLJ5MXXSy@bombadil.infradead.org>
References: <20230720140452.63817-1-hch@lst.de>
 <20230720140452.63817-3-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230720140452.63817-3-hch@lst.de>
Sender: Luis Chamberlain <mcgrof@infradead.org>
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 20, 2023 at 04:04:48PM +0200, Christoph Hellwig wrote:
> block_page_mkwrite_return is neither block nor mkwrite specific, and
> should not be under CONFIG_BLOCK.  Move it to mm.h and rename it to
> vmf_fs_error.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

 Luis