Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [net 0/2] rxfh with custom RSS fixes
To:     Joe Damato <jdamato@fastly.com>, netdev@vger.kernel.org,
        saeedm@nvidia.com, tariqt@nvidia.com, ecree@solarflare.com,
        andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net,
        leon@kernel.org, pabeni@redhat.com, bhutchings@solarflare.com,
        arnd@arndb.de
Cc:     linux-kernel@vger.kernel.org
References: <20230723150658.241597-1-jdamato@fastly.com>
From:   Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <b52f55ef-f166-cd1a-85b5-5fe32fe5f525@gmail.com>
Date:   Mon, 24 Jul 2023 20:27:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20230723150658.241597-1-jdamato@fastly.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/07/2023 16:06, Joe Damato wrote:
> Greetings:
> 
> While attempting to get the RX flow hash key for a custom RSS context on
> my mlx5 NIC, I got an error:
> 
> $ sudo ethtool -u eth1 rx-flow-hash tcp4 context 1
> Cannot get RX network flow hashing options: Invalid argument
> 
> I dug into this a bit and noticed two things:
> 
> 1. ETHTOOL_GRXFH supports custom RSS contexts, but ETHTOOL_SRXFH does
> not. I moved the copy logic out of ETHTOOL_GRXFH and into a helper so
> that both ETHTOOL_{G,S}RXFH now call it, which fixes ETHTOOL_SRXFH. This
> is patch 1/2.

As I see it, this is a new feature, not a fix, so belongs on net-next.
(No existing driver accepts FLOW_RSS in ETHTOOL_SRXFH's cmd->flow_type,
 which is just as well as if they did this would be a uABI break.)

Going forward, ETHTOOL_SRXFH will hopefully be integrated into the new
 RSS context kAPI I'm working on[1], so that we can have a new netlink
 uAPI for RSS configuration that's all in one place instead of the
 piecemeal-grown ethtool API with its backwards-compatible hacks.
But that will take a while, so I think this should go in even though
 it's technically an extension to legacy ethtool; it was part of the
 documented uAPI and userland implements it, it just never got
 implemented on the kernel side (because the initial driver with
 context support, sfc, didn't support SRXFH).

> 2. mlx5 defaulted to RSS context 0 for both ETHTOOL_{G,S}RXFH paths. I
> have modified the driver to support custom contexts for both paths. It
> is now possible to get and set the flow hash key for custom RSS contexts
> with mlx5. This is patch 2/2.

My feeling would be that this isn't a Fix either, but not my place to say.

-ed

[1]: https://lore.kernel.org/netdev/ecaae93a-d41d-4c3d-8e52-2800baa7080d@lunn.ch/T/