Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3594108rwo; Mon, 24 Jul 2023 13:32:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlFA8ZNku3Wj1CYDe8aR7e3fM0mFh2/xhkGZdoB5/AMsoP1dCRomYCfYp13ZTDH08eH7v+F1 X-Received: by 2002:a05:6512:10cc:b0:4fb:c885:425 with SMTP id k12-20020a05651210cc00b004fbc8850425mr6358294lfg.9.1690230734627; Mon, 24 Jul 2023 13:32:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690230734; cv=none; d=google.com; s=arc-20160816; b=aoXot9j16epoVIyOaOSG75rQIjWCm7nCKBc2PVpBS1XTnZkQ9mWy4/t5RmEUSWniyd n+40OwqfhN1fwfx44HGQZy59Ct7bVmm159JHNG0vwY/70lc+ji3LmxBco/Hke8R97DWo Gh2r94Ur1tkapdF3WpXuG50KVE6z5kS5AD4y1yCeGwTcx+y6FT6jXZwtyTzHt8KYppag ujLzTRSnFBZuMZN+dCBZ55zP2AjJAifK2es2RiElWdw0yxmcC/bAXk6+dgDVB5VdbN50 z5CDmz8IJVSbL5b7x9+rPfcBxlgJx0lQqRZrabXxBY6V7zun20UtO1I2UyoBSSVlC4a4 nCXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=J5wWW1EtFpBIR05IfxoMHzoYojyakUH8TdbRyvGIOTM=; fh=+QmlZwWFsiRq/+iEZXod2XzTeEk8UoLMI4fSK6R8UcQ=; b=kuyZE730QPd2iJzA/uwOTFM+L+KveXAS5IVqkk7bb92ReP0l2HQFGNTBV1y4hm0wHT JvHvoqNXaeAbRk/rVpwcIsu4dVj555MBAuEoeLemxxBv6A2M3TPEoJ2eJImyiQjw2LrQ C8w/ZetLPlBXycA8OSKXqcqbPgGAHWRIMVlntqT6a4ZhDwENqgzeswG5CAv2RE+YQclz jyJ3izZ4wazeO4NydcFbR9mxqoE+PO9HXamrX4HTZOgUgU/g/zIXtvMNjtZ8qrbC8jcj SEv2WYSCDhy8ChA0x7kIntEiFSo88P9HEHTHQON4GJkU9qXy/wHwMrwsjSRHr+vg5Wr0 8SIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dqbo8Cdn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a05640203ca00b005223c4a404bsi835209edw.449.2023.07.24.13.31.48; Mon, 24 Jul 2023 13:32:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dqbo8Cdn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbjGXUHT (ORCPT + 99 others); Mon, 24 Jul 2023 16:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjGXUHS (ORCPT ); Mon, 24 Jul 2023 16:07:18 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D13C110D8; Mon, 24 Jul 2023 13:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J5wWW1EtFpBIR05IfxoMHzoYojyakUH8TdbRyvGIOTM=; b=dqbo8CdnSUk9Z9Q0jUU79AqTgR TcWOjjUyjkkqeo5PB4ZrIkdlieYkyVRlJz4+DZ/8w3Q7GyAlVp0Mi+OmD03aJA63T+0mpGefhi553 M7GK397iMH4Jhak7mEis7MKfTe9ZvaxGo6zqwniAQry17ceBmQCT0NU8ciNTW1scF3v+rcsdI9Dk7 5Ld6dKPI0RWwdnUZ1uIFHQuVG3oRbrHUQIZm9ftpPcY1zxbFCFV8P3xuJIVU+VeGEU/VSPgWZzfdn AW4QYe+T0gskK/0hgNMWahfGIYEN4zUYPn7qZtk/EGuCBdWA0AauEY9/uwE13etR5+a8M4icYNLzl RVDEpyAg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qO1pp-005MNS-2u; Mon, 24 Jul 2023 20:07:13 +0000 Date: Mon, 24 Jul 2023 13:07:13 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: Jens Axboe , "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] block: stop setting ->direct_IO Message-ID: References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720140452.63817-5-hch@lst.de> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 04:04:50PM +0200, Christoph Hellwig wrote: > Direct I/O on block devices now nevers goes through aops->direct_IO. > Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead. > > Signed-off-by: Christoph Hellwig Reviewed-by: Luis Chamberlain Luis